net/url_request/url_request_job_factory.h - Issue 11227017: Remove the mutation functions interfaces from URLRequestJobFactory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_job_factory.h

Issue 11227017: Remove the mutation functions interfaces from URLRequestJobFactory. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix Android Webview interfaces; also a long awaited rebase. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/url_request/url_request_job_factory.h

diff --git a/net/url_request/url_request_job_factory.h b/net/url_request/url_request_job_factory.h

index adff7f1d818ef46c679d2b93d53aa6dbe503feeb..ca234a37da4898bfaa724a6a6b977041a1d2c91d 100644

--- a/net/url_request/url_request_job_factory.h

+++ b/net/url_request/url_request_job_factory.h

@@ -74,18 +74,6 @@ class NET_EXPORT URLRequestJobFactory

URLRequestJobFactory();

virtual ~URLRequestJobFactory();

- // TODO(shalev): Remove this from the interface.

- // Sets the ProtocolHandler for a scheme. Returns true on success, false on

- // failure (a ProtocolHandler already exists for |scheme|). On success,

- // URLRequestJobFactory takes ownership of |protocol_handler|.

- virtual bool SetProtocolHandler(const std::string& scheme,

- ProtocolHandler* protocol_handler) = 0;

- // TODO(shalev): Remove this from the interface.

- // Takes ownership of |interceptor|. Adds it to the end of the Interceptor

- // list.

- virtual void AddInterceptor(Interceptor* interceptor) = 0;

// TODO(shalev): Consolidate MaybeCreateJobWithInterceptor and

// MaybeCreateJobWithProtocolHandler into a single method.

virtual URLRequestJob* MaybeCreateJobWithInterceptor(

« no previous file with comments | « net/url_request/protocol_intercept_job_factory.cc ('k') | net/url_request/url_request_job_factory_impl.h » ('j') | no next file with comments »