Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1990)

Unified Diff: net/url_request/url_request_job_factory_impl.h

Issue 11227017: Remove the mutation functions interfaces from URLRequestJobFactory. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix Android Webview interfaces; also a long awaited rebase. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_job_factory.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_job_factory_impl.h
diff --git a/net/url_request/url_request_job_factory_impl.h b/net/url_request/url_request_job_factory_impl.h
index ff27185a8573a728ed85fad93558ecb2f087351a..b98cf0caab220fa12a1b0b6ac3a416c0b44333b9 100644
--- a/net/url_request/url_request_job_factory_impl.h
+++ b/net/url_request/url_request_job_factory_impl.h
@@ -19,9 +19,6 @@ class NET_EXPORT URLRequestJobFactoryImpl : public URLRequestJobFactory {
virtual ~URLRequestJobFactoryImpl();
// URLRequestJobFactory implementation
- virtual bool SetProtocolHandler(const std::string& scheme,
- ProtocolHandler* protocol_handler) OVERRIDE;
- virtual void AddInterceptor(Interceptor* interceptor) OVERRIDE;
virtual URLRequestJob* MaybeCreateJobWithInterceptor(
URLRequest* request, NetworkDelegate* network_delegate) const OVERRIDE;
virtual URLRequestJob* MaybeCreateJobWithProtocolHandler(
@@ -37,6 +34,16 @@ class NET_EXPORT URLRequestJobFactoryImpl : public URLRequestJobFactory {
virtual bool IsHandledProtocol(const std::string& scheme) const OVERRIDE;
virtual bool IsHandledURL(const GURL& url) const OVERRIDE;
+ // Sets the ProtocolHandler for a scheme. Returns true on success, false on
+ // failure (a ProtocolHandler already exists for |scheme|). On success,
+ // URLRequestJobFactory takes ownership of |protocol_handler|.
+ bool SetProtocolHandler(const std::string& scheme,
+ ProtocolHandler* protocol_handler);
+
+ // Takes ownership of |interceptor|. Adds it to the end of the Interceptor
+ // list.
+ void AddInterceptor(Interceptor* interceptor);
+
private:
typedef std::map<std::string, ProtocolHandler*> ProtocolHandlerMap;
typedef std::vector<Interceptor*> InterceptorList;
« no previous file with comments | « net/url_request/url_request_job_factory.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698