Backfill some FX String unit tests for == and !=.

core/src/fxcrt/fx_basic_bstring_unittest.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "../../../testing/fx_string_testhelpers.h"
 #include "../../include/fxcrt/fx_basic.h"
 
 TEST(fxcrt, ByteStringOperatorSubscript) {
     // CFX_ByteString includes the NUL terminator for non-empty strings.
@@ skipping 27 matching lines @@
     EXPECT_TRUE(a < abc);
     EXPECT_FALSE(abc < a);
 
     EXPECT_TRUE(a < def);
     EXPECT_FALSE(def < a);
 
     EXPECT_TRUE(abc < def);
     EXPECT_FALSE(def < abc);
 }
 
+TEST(fxcrt, ByteStringOperatorEQ) {
+    CFX_ByteString byte_string("hello");
+    ASSERT_TRUE(byte_string == byte_string);
+
+    CFX_ByteString byte_string_same1("hello");
+    ASSERT_TRUE(byte_string == byte_string_same1);
+    ASSERT_TRUE(byte_string_same1 == byte_string);
+
+    CFX_ByteString byte_string_same2(byte_string);
+    ASSERT_TRUE(byte_string == byte_string_same2);
+    ASSERT_TRUE(byte_string_same2 == byte_string);
+
+    CFX_ByteString byte_string1("he");
+    CFX_ByteString byte_string2("hellp");
+    CFX_ByteString byte_string3("hellod");
+    ASSERT_FALSE(byte_string == byte_string1);
+    ASSERT_FALSE(byte_string == byte_string2);
+    ASSERT_FALSE(byte_string == byte_string3);
+    ASSERT_FALSE(byte_string1 == byte_string);
+    ASSERT_FALSE(byte_string2 == byte_string);
+    ASSERT_FALSE(byte_string3 == byte_string);
+
+    CFX_ByteStringC byte_string_c_same1("hello");
+    ASSERT_TRUE(byte_string == byte_string_c_same1);
+    ASSERT_TRUE(byte_string_c_same1 == byte_string);
+
+    CFX_ByteStringC byte_string_c1("he");
+    CFX_ByteStringC byte_string_c2("hellp");
+    CFX_ByteStringC byte_string_c3("hellod");
+    ASSERT_FALSE(byte_string == byte_string_c1);
+    ASSERT_FALSE(byte_string == byte_string_c2);
+    ASSERT_FALSE(byte_string == byte_string_c3);
+    ASSERT_FALSE(byte_string_c1 == byte_string);
+    ASSERT_FALSE(byte_string_c2 == byte_string);
+    ASSERT_FALSE(byte_string_c3 == byte_string);
+
+    const char* c_string_same1 = "hello";
+    ASSERT_TRUE(byte_string == c_string_same1);
+#if 0
+    // TODO(tsepez): See, you don't want implicit c_str() casting.
+    // This degrades to a pointer comparision, which flunks.
+    ASSERT_TRUE(c_string_same1 == byte_string);
+#endif
+
+    const char* c_string1 = "he";
+    const char* c_string2 = "hellp";
+    const char* c_string3 = "hellod";
+    ASSERT_FALSE(byte_string == c_string1);
+    ASSERT_FALSE(byte_string == c_string2);
+    ASSERT_FALSE(byte_string == c_string3);
+    ASSERT_FALSE(c_string1 == byte_string);
+    ASSERT_FALSE(c_string2 == byte_string);
+    ASSERT_FALSE(c_string3 == byte_string);
+}
+
+TEST(fxcrt, ByteStringOperatorNE) {
+    CFX_ByteString byte_string("hello");
+    ASSERT_FALSE(byte_string != byte_string);
+
+    CFX_ByteString byte_string_same1("hello");
+    ASSERT_FALSE(byte_string != byte_string_same1);
+    ASSERT_FALSE(byte_string_same1 != byte_string);
+
+    CFX_ByteString byte_string_same2(byte_string);
+    ASSERT_FALSE(byte_string != byte_string_same2);
+    ASSERT_FALSE(byte_string_same2 != byte_string);
+
+    CFX_ByteString byte_string1("he");
+    CFX_ByteString byte_string2("hellp");
+    CFX_ByteString byte_string3("hellod");
+    ASSERT_TRUE(byte_string != byte_string1);
+    ASSERT_TRUE(byte_string != byte_string2);
+    ASSERT_TRUE(byte_string != byte_string3);
+    ASSERT_TRUE(byte_string1 != byte_string);
+    ASSERT_TRUE(byte_string2 != byte_string);
+    ASSERT_TRUE(byte_string3 != byte_string);
+
+    CFX_ByteStringC byte_string_c_same1("hello");
+    ASSERT_FALSE(byte_string != byte_string_c_same1);
+    ASSERT_FALSE(byte_string_c_same1 != byte_string);
+
+    CFX_ByteStringC byte_string_c1("he");
+    CFX_ByteStringC byte_string_c2("hellp");
+    CFX_ByteStringC byte_string_c3("hellod");
+    ASSERT_TRUE(byte_string != byte_string_c1);
+    ASSERT_TRUE(byte_string != byte_string_c2);
+    ASSERT_TRUE(byte_string != byte_string_c3);
+    ASSERT_TRUE(byte_string_c1 != byte_string);
+    ASSERT_TRUE(byte_string_c2 != byte_string);
+    ASSERT_TRUE(byte_string_c3 != byte_string);
+
+    const char* c_string_same1 = "hello";
+    ASSERT_FALSE(byte_string != c_string_same1);
+#if 0
+    // See above TODO.
+    ASSERT_FALSE(c_string_same1 != byte_string);
+#endif
+    const char* c_string1 = "he";
+    const char* c_string2 = "hellp";
+    const char* c_string3 = "hellod";
+    ASSERT_TRUE(byte_string != c_string1);
+    ASSERT_TRUE(byte_string != c_string2);
+    ASSERT_TRUE(byte_string != c_string3);
+    ASSERT_TRUE(c_string1 != byte_string);
+    ASSERT_TRUE(c_string2 != byte_string);
+    ASSERT_TRUE(c_string3 != byte_string);
+}
+
 TEST(fxcrt, ByteStringCNull) {
   CFX_ByteStringC null_string;
   EXPECT_EQ(null_string.GetPtr(), nullptr);
   EXPECT_EQ(null_string.GetLength(), 0);
   EXPECT_TRUE(null_string.IsEmpty());
 
   CFX_ByteStringC another_null_string;
   EXPECT_EQ(null_string, another_null_string);
 
   CFX_ByteStringC copied_null_string(null_string);
@@ skipping 203 matching lines @@
 
     EXPECT_TRUE(a < abc);
     EXPECT_FALSE(abc < a);
 
     EXPECT_TRUE(a < def);
     EXPECT_FALSE(def < a);
 
     EXPECT_TRUE(abc < def);
     EXPECT_FALSE(def < abc);
 }