Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1122503003: Display isolate message queue in Observatory debugger (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 27835474194afbb9b38ca5728ceaf8d18b4af163..748aada12efe16938f708ecd163e44199b362f48 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -80,6 +80,9 @@ abstract class ServiceObject extends Observable {
bool get isSentinel => type == 'Sentinel';
bool get isString => type == 'String';
+ // Is this an isolate message?
turnidge 2015/05/04 17:47:12 Not sure that this comment adds, given that none o
Cutch 2015/05/04 19:56:51 Done.
+ bool get isIsolateMessage => type == 'IsolateMessage';
+
// Kinds of Instance.
bool get isMirrorReference => vmType == 'MirrorReference';
bool get isWeakProperty => vmType == 'WeakProperty';
@@ -2209,6 +2212,7 @@ class Script extends ServiceObject with Coverage {
if (mapIsRef) {
return;
}
+ _loaded = true;
lineOffset = map['lineOffset'];
columnOffset = map['columnOffset'];
_parseTokenPosTable(map['tokenPosTable']);
@@ -2282,8 +2286,6 @@ class Script extends ServiceObject with Coverage {
}
void _processSource(String source) {
- // Preemptyively mark that this is not loaded.
- _loaded = false;
if (source == null) {
return;
}
@@ -2291,8 +2293,6 @@ class Script extends ServiceObject with Coverage {
if (sourceLines.length == 0) {
return;
}
- // We have the source to the script. This is now loaded.
- _loaded = true;
lines.clear();
Logger.root.info('Adding ${sourceLines.length} source lines for ${_url}');
for (var i = 0; i < sourceLines.length; i++) {

Powered by Google App Engine
This is Rietveld 408576698