runtime/observatory/lib/src/elements/script_ref.dart - Issue 1122503003: Display isolate message queue in Observatory debugger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/script_ref.dart

Issue 1122503003: Display isolate message queue in Observatory debugger (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/observatory/lib/src/elements/debugger.html ('K') | « runtime/observatory/lib/src/elements/debugger.html ('k') | runtime/observatory/lib/src/service/object.dart » ('j') | runtime/observatory/lib/src/service/object.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/lib/src/elements/script_ref.dart

diff --git a/runtime/observatory/lib/src/elements/script_ref.dart b/runtime/observatory/lib/src/elements/script_ref.dart

index 2f30e26b38b299c4268635f42e52dd687aa7040d..d467fc604e25c1b64de968b4a115b175ee9d680a 100644

--- a/runtime/observatory/lib/src/elements/script_ref.dart

+++ b/runtime/observatory/lib/src/elements/script_ref.dart

@@ -34,7 +34,7 @@ class ScriptRefElement extends ServiceRefElement {

if (ref == null) {

return super.name;

}

- if (pos >= 0) {

+ if ((pos != null) && (pos >= 0)) {

if (ref.loaded) {

// Script is loaded, get the line number.

Script script = ref;

@@ -51,7 +51,7 @@ class ScriptRefElement extends ServiceRefElement {

if (ref == null) {

return super.url;

}

- if (pos >= 0) {

+ if ((pos != null) && (pos >= 0)) {

if (ref.loaded) {

return '${super.url}---pos=${pos}';

} else {