Issue 11225: Fix a proto-type mismatch on a virtual override.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11225: Fix a proto-type mismatch on a virtual override. (Closed)

Created:
12 years, 1 month ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
agl, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix a proto-type mismatch on a virtual override. This was causing us to create a SkDevice instead of creating our special platform device type instead. This fixes one of the main Linux crashes.

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	src/base/gfx/platform_canvas_linux.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/base/gfx/platform_canvas_linux.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

This was awesome.

Expand Messages | Collapse Messages