Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1122313002: Typing fixes to eliminate casts/dcalls (Closed)

Created:
5 years, 7 months ago by Leaf
Modified:
5 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Typing fixes to eliminate casts/dcalls Tightens up some typing issues (mostly in the collections) to eliminate some casts and dynamic calls. Also adds inference through parenthesized expressions. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/ca517db3505eb4b66c16f506317164b32fae71f0

Patch Set 1 #

Patch Set 2 : Minor fixes #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+326 lines, -377 lines) Patch
M lib/runtime/dart/async.js View 1 2 16 chunks +34 lines, -39 lines 0 comments Download
M lib/runtime/dart/collection.js View 1 2 38 chunks +61 lines, -106 lines 0 comments Download
M lib/runtime/dart/convert.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/core.js View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/checker/rules.dart View 1 2 chunks +8 lines, -0 lines 0 comments Download
M test/checker/checker_test.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/dart_codegen/expect/async/stream.dart View 1 2 17 chunks +25 lines, -29 lines 0 comments Download
M test/dart_codegen/expect/async/stream_controller.dart View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M test/dart_codegen/expect/async/stream_impl.dart View 1 2 5 chunks +13 lines, -13 lines 0 comments Download
M test/dart_codegen/expect/async/stream_pipe.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/async/stream_transformers.dart View 1 2 2 chunks +11 lines, -11 lines 0 comments Download
M test/dart_codegen/expect/async/timer.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/async/zone.dart View 1 2 9 chunks +18 lines, -18 lines 0 comments Download
M test/dart_codegen/expect/collection/hash_map.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/collection/iterable.dart View 1 2 3 chunks +13 lines, -13 lines 0 comments Download
M test/dart_codegen/expect/collection/set.dart View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M test/dart_codegen/expect/collection/splay_tree.dart View 1 2 21 chunks +46 lines, -61 lines 0 comments Download
M test/generated_sdk/lib/collection/collection.dart View 4 chunks +10 lines, -8 lines 0 comments Download
M test/generated_sdk/lib/collection/hash_map.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M test/generated_sdk/lib/collection/hash_set.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/generated_sdk/lib/collection/iterable.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M test/generated_sdk/lib/collection/linked_hash_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/generated_sdk/lib/collection/linked_hash_set.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/generated_sdk/lib/collection/set.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M test/generated_sdk/lib/collection/splay_tree.dart View 7 chunks +11 lines, -9 lines 0 comments Download
M test/generated_sdk/lib/core/list.dart View 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/lib/collection/hash_map.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tool/input_sdk/lib/collection/iterable.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M tool/input_sdk/lib/collection/set.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tool/input_sdk/lib/collection/splay_tree.dart View 7 chunks +11 lines, -9 lines 0 comments Download
M tool/input_sdk/patch/collection_patch.dart View 8 chunks +14 lines, -12 lines 0 comments Download
M tool/input_sdk/patch/core_patch.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Leaf
5 years, 7 months ago (2015-05-05 20:19:15 UTC) #2
vsm
lgtm
5 years, 7 months ago (2015-05-05 22:08:27 UTC) #3
Leaf
5 years, 7 months ago (2015-05-05 23:47:23 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
ca517db3505eb4b66c16f506317164b32fae71f0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698