Typing fixes to eliminate casts/dcalls

tool/input_sdk/patch/collection_patch.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Patch file for dart:collection classes.
 import 'dart:_foreign_helper' show JS;
 import 'dart:_js_helper' show
     fillLiteralMap, InternalMap, NoInline, NoThrows, patch;
 
 @patch
 class HashMap<K, V> {
   @patch
   factory HashMap({ bool equals(K key1, K key2),
                     int hashCode(K key),
-                    bool isValidKey(potentialKey) }) {
+                    bool isValidKey(Object potentialKey) }) {
     if (isValidKey == null) {
       if (hashCode == null) {
         if (equals == null) {
           return new _HashMap<K, V>();
         }
         hashCode = _defaultHashCode;
       } else {
         if (identical(identityHashCode, hashCode) &&
             identical(identical, equals)) {
           return new _IdentityHashMap<K, V>();
@@ skipping 351 matching lines @@
     for (int i = 0; i < length; i += 2) {
       if (identical(JS('var', '#[#]', bucket, i), key)) return i;
     }
     return -1;
   }
 }
 
 class _CustomHashMap<K, V> extends _HashMap<K, V> {
   final _Equality<K> _equals;
   final _Hasher<K> _hashCode;
-  final _Predicate _validKey;
-  _CustomHashMap(this._equals, this._hashCode, bool validKey(potentialKey))
+  final _Predicate<Object> _validKey;
+  _CustomHashMap(this._equals, this._hashCode,
+                 bool validKey(Object potentialKey))
       : _validKey = (validKey != null) ? validKey : ((v) => v is K);
 
   V operator[](Object key) {
     if (!_validKey(key)) return null;
     return super._get(key);
   }
 
   void operator[]=(K key, V value) {
     super._set(key, value);
   }
@@ skipping 81 matching lines @@
       return true;
     }
   }
 }
 
 @patch
 class LinkedHashMap<K, V> {
   @patch
   factory LinkedHashMap({ bool equals(K key1, K key2),
                           int hashCode(K key),
-                          bool isValidKey(potentialKey) }) {
+                          bool isValidKey(Object potentialKey) }) {
     if (isValidKey == null) {
       if (hashCode == null) {
         if (equals == null) {
           return new _LinkedHashMap<K, V>();
         }
         hashCode = _defaultHashCode;
       } else {
         if (identical(identityHashCode, hashCode) &&
             identical(identical, equals)) {
           return new _LinkedIdentityHashMap<K, V>();
@@ skipping 351 matching lines @@
       LinkedHashMapCell cell = JS('var', '#[#]', bucket, i);
       if (identical(cell._key, key)) return i;
     }
     return -1;
   }
 }
 
 class _LinkedCustomHashMap<K, V> extends _LinkedHashMap<K, V> {
   final _Equality<K> _equals;
   final _Hasher<K> _hashCode;
-  final _Predicate _validKey;
+  final _Predicate<Object> _validKey;
   _LinkedCustomHashMap(this._equals, this._hashCode,
-                       bool validKey(potentialKey))
+                       bool validKey(Object potentialKey))
       : _validKey = (validKey != null) ? validKey : ((v) => v is K);
 
   V operator[](Object key) {
     if (!_validKey(key)) return null;
     return super._get(key);
   }
 
   void operator[]=(K key, V value) {
     super._set(key, value);
   }
@@ skipping 89 matching lines @@
       return true;
     }
   }
 }
 
 @patch
 class HashSet<E> {
   @patch
   factory HashSet({ bool equals(E e1, E e2),
                     int hashCode(E e),
-                    bool isValidKey(potentialKey) }) {
+                    bool isValidKey(Object potentialKey) }) {
     if (isValidKey == null) {
       if (hashCode == null) {
         if (equals == null) {
           return new _HashSet<E>();
         }
         hashCode = _defaultHashCode;
       } else {
         if (identical(identityHashCode, hashCode) &&
             identical(identical, equals)) {
           return new _IdentityHashSet<E>();
@@ skipping 308 matching lines @@
     for (int i = 0; i < length; i++) {
       if (identical(JS('var', '#[#]', bucket, i), element)) return i;
     }
     return -1;
   }
 }
 
 class _CustomHashSet<E> extends _HashSet<E> {
   _Equality<E> _equality;
   _Hasher<E> _hasher;
-  _Predicate _validKey;
-  _CustomHashSet(this._equality, this._hasher, bool validKey(potentialKey))
+  _Predicate<Object> _validKey;
+  _CustomHashSet(this._equality, this._hasher,
+                 bool validKey(Object potentialKey))
       : _validKey = (validKey != null) ? validKey : ((x) => x is E);
 
   Set<E> _newSet() => new _CustomHashSet<E>(_equality, _hasher, _validKey);
 
   int _findBucketIndex(var bucket, var element) {
     if (bucket == null) return -1;
     int length = JS('int', '#.length', bucket);
     for (int i = 0; i < length; i++) {
       if (_equality(JS('var', '#[#]', bucket, i), element)) return i;
     }
@@ skipping 54 matching lines @@
       return true;
     }
   }
 }
 
 @patch
 class LinkedHashSet<E> {
   @patch
   factory LinkedHashSet({ bool equals(E e1, E e2),
                           int hashCode(E e),
-                          bool isValidKey(potentialKey) }) {
+                          bool isValidKey(Object potentialKey) }) {
     if (isValidKey == null) {
       if (hashCode == null) {
         if (equals == null) {
           return new _LinkedHashSet<E>();
         }
         hashCode = _defaultHashCode;
       } else {
         if (identical(identityHashCode, hashCode) &&
             identical(identical, equals)) {
           return new _LinkedIdentityHashSet<E>();
@@ skipping 345 matching lines @@
       LinkedHashSetCell cell = JS('var', '#[#]', bucket, i);
       if (identical(cell._element, element)) return i;
     }
     return -1;
   }
 }
 
 class _LinkedCustomHashSet<E> extends _LinkedHashSet<E> {
   _Equality<E> _equality;
   _Hasher<E> _hasher;
-  _Predicate _validKey;
+  _Predicate<Object> _validKey;
   _LinkedCustomHashSet(this._equality, this._hasher,
-                       bool validKey(potentialKey))
+                       bool validKey(Object potentialKey))
       : _validKey = (validKey != null) ? validKey : ((x) => x is E);
 
   Set<E> _newSet() =>
       new _LinkedCustomHashSet<E>(_equality, _hasher, _validKey);
 
   int _findBucketIndex(var bucket, var element) {
     if (bucket == null) return -1;
     int length = JS('int', '#.length', bucket);
     for (int i = 0; i < length; i++) {
       LinkedHashSetCell cell = JS('var', '#[#]', bucket, i);
@@ skipping 71 matching lines @@
     } else if (_cell == null) {
       _current = null;
       return false;
     } else {
       _current = _cell._element;
       _cell = _cell._next;
       return true;
     }
   }
 }