Issue 11221002: Merge 162639 - Implement size and position support for launchWebAuthFlow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11221002: Merge 162639 - Implement size and position support for launchWebAuthFlow. (Closed)

Created:
8 years, 2 months ago by Mihai Parparita -not on Chrome

Modified:
8 years, 2 months ago

Reviewers:
Mihai Parparita -not on Chrome

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1271/src/

Visibility:
Public.

Merge 162639 - Implement size and position support for launchWebAuthFlow. Also fix a bug where we would still try to close WebContents in a WebAuthFlow where the contents had already been destroyed. Also remove some indentity API test files, the test that used them was removed with r148017. BUG=132143 R=munjal@chromium.org Review URL: https://chromiumcodereview.appspot.com/11186036 TBR=mihaip@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162715

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+106 lines, -43 lines)			Patch
M	chrome/browser/extensions/api/identity/identity_api.cc	View	2 chunks	+17 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/identity/identity_apitest.cc	View	3 chunks	+63 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/identity/web_auth_flow.h	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/identity/web_auth_flow.cc	View	3 chunks	+8 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/identity/web_auth_flow_unittest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/extensions/api/experimental_identity.idl	View	1 chunk	+12 lines, -0 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/identity/manifest.json	View	1 chunk	+0 lines, -12 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/identity/test.js	View	1 chunk	+0 lines, -23 lines	0 comments	Download

Total messages: 1 (0 generated)