Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: content/renderer/render_view_impl.cc

Issue 112203003: Fix renderer crashes when frame gets detached while injectng user scripts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated patch to latest WebFrame/Frame lifetime changes. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 9d413a1658424cbf7e5148a4861730ed64f1c3a7..9960d3d8ce4b72e8b284b66c5d819a7f0f7f3f76 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -3698,7 +3698,8 @@ void RenderViewImpl::didFinishDocumentLoad(WebFrame* frame) {
DidFinishDocumentLoad(frame));
// Check whether we have new encoding name.
- UpdateEncoding(frame, frame->view()->pageEncoding().utf8());
+ if (frame->view())
dcheng 2014/02/07 16:53:37 Might be good to add a comment on why you need to
+ UpdateEncoding(frame, frame->view()->pageEncoding().utf8());
}
void RenderViewImpl::didHandleOnloadEvents(WebFrame* frame) {
« chrome/renderer/extensions/user_script_slave.cc ('K') | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698