content/renderer/render_view_impl.h - Issue 112203003: Fix renderer crashes when frame gets detached while injectng user scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 112203003: Fix renderer crashes when frame gets detached while injectng user scripts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated patch to latest WebFrame/Frame lifetime changes. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/extensions/user_script_slave.cc ('K') | « content/renderer/render_view_browsertest.cc ('k') | content/renderer/render_view_impl.cc » ('j') | content/renderer/render_view_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index 86110460c3bec35580bcf05b5520821387c6b7eb..5f8c7cea338999c6f6ebb5581278a6b9d7ccc46b 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -809,6 +809,9 @@ class CONTENT_EXPORT RenderViewImpl

FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, SendCandidateWindowEvents);

FRIEND_TEST_ALL_PREFIXES(SuppressErrorPageTest, Suppresses);

FRIEND_TEST_ALL_PREFIXES(SuppressErrorPageTest, DoesNotSuppress);

+ FRIEND_TEST_ALL_PREFIXES(SynchronousFrameRemovalOnLoadTest,

+ DynamicallyInsertedFrame);

+ FRIEND_TEST_ALL_PREFIXES(SynchronousFrameRemovalOnLoadTest, StaticFrame);

typedef std::map<GURL, double> HostZoomLevels;