 Chromium Code Reviews
 Chromium Code Reviews Issue 112203003:
  Fix renderer crashes when frame gets detached while injectng user scripts.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 112203003:
  Fix renderer crashes when frame gets detached while injectng user scripts.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: content/renderer/render_view_impl.cc | 
| diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc | 
| index 9d413a1658424cbf7e5148a4861730ed64f1c3a7..9960d3d8ce4b72e8b284b66c5d819a7f0f7f3f76 100644 | 
| --- a/content/renderer/render_view_impl.cc | 
| +++ b/content/renderer/render_view_impl.cc | 
| @@ -3698,7 +3698,8 @@ void RenderViewImpl::didFinishDocumentLoad(WebFrame* frame) { | 
| DidFinishDocumentLoad(frame)); | 
| // Check whether we have new encoding name. | 
| - UpdateEncoding(frame, frame->view()->pageEncoding().utf8()); | 
| + if (frame->view()) | 
| 
dcheng
2014/02/07 16:53:37
Might be good to add a comment on why you need to
 | 
| + UpdateEncoding(frame, frame->view()->pageEncoding().utf8()); | 
| } | 
| void RenderViewImpl::didHandleOnloadEvents(WebFrame* frame) { |