Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3397)

Unified Diff: ash/shelf/shelf_layout_manager.cc

Issue 1121893004: Have Notifications appear over docked windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shelf/shelf_layout_manager.cc
diff --git a/ash/shelf/shelf_layout_manager.cc b/ash/shelf/shelf_layout_manager.cc
index 1971f62e63b7e9dcf4eed06afcea088367719c3e..3d9e6a5793935bf5ec76a1dd1209bc3d7b1615d0 100644
--- a/ash/shelf/shelf_layout_manager.cc
+++ b/ash/shelf/shelf_layout_manager.cc
@@ -1119,11 +1119,11 @@ void ShelfLayoutManager::OnKeyboardBoundsChanging(const gfx::Rect& new_bounds) {
void ShelfLayoutManager::OnDockBoundsChanging(
const gfx::Rect& dock_bounds,
DockedWindowLayoutManagerObserver::Reason reason) {
- // Skip shelf layout in case docked notification originates from this class.
- if (reason == DISPLAY_INSETS_CHANGED)
- return;
if (dock_bounds_ != dock_bounds) {
dock_bounds_ = dock_bounds;
+ // Skip shelf layout in case docked notification originates from this class.
+ if (reason == DISPLAY_INSETS_CHANGED)
+ return;
OnWindowResized();
UpdateVisibilityState();
UpdateShelfBackground(BACKGROUND_CHANGE_ANIMATE);

Powered by Google App Engine
This is Rietveld 408576698