ash/system/web_notification/ash_popup_alignment_delegate.cc - Issue 1121893004: Have Notifications appear over docked windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/web_notification/ash_popup_alignment_delegate.cc

Issue 1121893004: Have Notifications appear over docked windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/system/web_notification/ash_popup_alignment_delegate.cc

diff --git a/ash/system/web_notification/ash_popup_alignment_delegate.cc b/ash/system/web_notification/ash_popup_alignment_delegate.cc

index 96ffc795396cf4012729cf0d80a5998fdd3ee688..b4aec7f60913dfb914644dddc69fe687e356c589 100644

--- a/ash/system/web_notification/ash_popup_alignment_delegate.cc

+++ b/ash/system/web_notification/ash_popup_alignment_delegate.cc

@@ -149,6 +149,9 @@ void AshPopupAlignmentDelegate::UpdateWorkArea(const gfx::Display& display,

gfx::Insets(0, 0, 0, width),

gfx::Insets(width, 0, 0, 0)));

+ if (shelf_)

+ work_area_.Union(shelf_->dock_bounds());

oshima 2015/05/06 21:01:18 I don't think this is correct. let me take a look.

jonross 2015/05/07 18:54:27 Updated per offline discussions. ShelfLayoutManage

DoUpdateIfPossible();

}