Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1121783003: Move navigations with POST or referrer to the shell. (Closed)

Created:
5 years, 7 months ago by jam
Modified:
5 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move navigations with POST or referrer to the shell. Previously we were doing them inside html_viewer because NavigatorHost was throwing out that extra data before it got to the network service. The fix is to pass through this url request information. Also: -add support for netlog to make debugging network issues easier. Use --log-net-log=file_path -ensure that mojo shell uses the same user agent as html_viewer. since this UA is sent to websites, they need to match or else there are bugs with Gmail (since it sees different UAs when logging in) BUG=481153 Committed: https://crrev.com/3cf73ae56fd339f5ce180ab39a0f6dd3e5aa4b1d Cr-Commit-Position: refs/heads/master@{#330864}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix gyp #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : netlog cleanup now that we have shutdown #

Patch Set 7 : fixes #

Total comments: 2

Patch Set 8 : review comments #

Patch Set 9 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+399 lines, -194 lines) Patch
M components/clipboard/clipboard_apptest.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M components/filesystem/files_test_base.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -1 line 0 comments Download
M components/html_viewer/ax_provider_apptest.cc View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M components/html_viewer/blink_platform_impl.cc View 1 2 3 4 4 chunks +9 lines, -9 lines 0 comments Download
M components/html_viewer/html_document.cc View 1 2 3 4 4 chunks +9 lines, -15 lines 0 comments Download
M components/html_viewer/html_viewer.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M components/html_viewer/web_media_player_factory.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M components/resource_provider/public/cpp/resource_loader.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M components/view_manager/DEPS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/view_manager/connection_manager.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/connection_manager.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M components/view_manager/connection_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/display_manager.cc View 1 2 3 4 2 chunks +6 lines, -2 lines 0 comments Download
M components/view_manager/public/cpp/lib/view.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/public/cpp/lib/view_manager_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/public/cpp/lib/view_manager_client_impl.cc View 1 2 3 4 1 chunk +6 lines, -4 lines 0 comments Download
M components/view_manager/public/cpp/lib/view_manager_context.cc View 1 2 3 4 2 chunks +8 lines, -4 lines 0 comments Download
M components/view_manager/public/cpp/lib/view_manager_init.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M components/view_manager/public/cpp/view.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/public/cpp/view_manager_context.h View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M components/view_manager/public/interfaces/BUILD.gn View 1 2 3 4 1 chunk +5 lines, -1 line 0 comments Download
M components/view_manager/public/interfaces/view_manager.mojom View 1 2 3 4 3 chunks +7 lines, -6 lines 0 comments Download
M components/view_manager/view_manager_app.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/view_manager_app.cc View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M components/view_manager/view_manager_service_apptest.cc View 1 2 3 4 2 chunks +7 lines, -3 lines 0 comments Download
M components/view_manager/view_manager_service_impl.h View 2 chunks +9 lines, -9 lines 0 comments Download
M components/view_manager/view_manager_service_impl.cc View 1 2 3 4 2 chunks +9 lines, -9 lines 0 comments Download
M components/view_manager/view_manager_service_unittest.cc View 1 2 3 4 4 chunks +11 lines, -6 lines 0 comments Download
M mandoline/ui/aura/surface_binding.cc View 1 2 3 4 2 chunks +6 lines, -2 lines 0 comments Download
M mandoline/ui/browser/BUILD.gn View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M mandoline/ui/browser/DEPS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/ui/browser/browser.h View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M mandoline/ui/browser/browser.cc View 1 2 3 4 7 chunks +22 lines, -16 lines 0 comments Download
M mandoline/ui/browser/desktop/desktop_ui.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M mandoline/ui/browser/navigator_host_impl.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M mandoline/ui/browser/view_embedder.mojom View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M mandoline/ui/omnibox/omnibox_impl.cc View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/application/public/cpp/application_impl.h View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/application/public/cpp/lib/application_impl.cc View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/application/public/interfaces/BUILD.gn View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/public/interfaces/shell.mojom View 1 2 3 4 2 chunks +6 lines, -3 lines 0 comments Download
M mojo/common/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/common/tracing_impl.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
A mojo/common/user_agent.h View 1 chunk +20 lines, -0 lines 0 comments Download
A mojo/common/user_agent.cc View 1 2 3 4 5 6 7 8 1 chunk +17 lines, -0 lines 0 comments Download
M mojo/mojo_base.gyp View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/mojo_services.gyp View 1 2 3 4 5 6 2 chunks +1 line, -17 lines 0 comments Download
M mojo/mojo_shell.gyp View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M mojo/runner/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/runner/context.cc View 1 2 3 4 2 chunks +8 lines, -4 lines 0 comments Download
M mojo/runner/native_runner_unittest.cc View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M mojo/runner/shell_test_base.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/services/network/http_server_apptest.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M mojo/services/network/network_context.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/network/network_context.cc View 1 2 3 4 5 6 3 chunks +53 lines, -3 lines 0 comments Download
M mojo/services/network/udp_socket_apptest.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M mojo/services/test_service/test_service_impl.cc View 1 2 3 4 2 chunks +6 lines, -2 lines 0 comments Download
M mojo/services/test_service/test_time_service_impl.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M mojo/shell/application_manager.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/application_manager.cc View 1 2 3 4 6 chunks +26 lines, -15 lines 0 comments Download
M mojo/shell/application_manager_unittest.cc View 1 2 3 4 4 chunks +10 lines, -3 lines 0 comments Download
M mojo/shell/fetcher.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/shell/local_fetcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/shell/local_fetcher.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/shell/network_fetcher.h View 3 chunks +4 lines, -2 lines 0 comments Download
M mojo/shell/network_fetcher.cc View 3 chunks +14 lines, -7 lines 0 comments Download
M mojo/shell/shell_impl.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/shell_impl.cc View 1 2 3 4 5 6 7 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/mojo/mojom_bindings_generator_explicit.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
jam
5 years, 7 months ago (2015-05-04 17:30:48 UTC) #5
jam
PTAL, this is now ready to review after the interfaces were forked.
5 years, 7 months ago (2015-05-20 20:26:26 UTC) #10
Ben Goodger (Google)
lgtm https://codereview.chromium.org/1121783003/diff/260001/mojo/shell/shell_impl.cc File mojo/shell/shell_impl.cc (right): https://codereview.chromium.org/1121783003/diff/260001/mojo/shell/shell_impl.cc#newcode45 mojo/shell/shell_impl.cc:45: void ShellImpl::ConnectToApplication(mojo::URLRequestPtr app_url, nit: app_request
5 years, 7 months ago (2015-05-20 21:17:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121783003/280001
5 years, 7 months ago (2015-05-20 22:04:59 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/65057) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 7 months ago (2015-05-20 22:17:46 UTC) #16
jam
https://codereview.chromium.org/1121783003/diff/260001/mojo/shell/shell_impl.cc File mojo/shell/shell_impl.cc (right): https://codereview.chromium.org/1121783003/diff/260001/mojo/shell/shell_impl.cc#newcode45 mojo/shell/shell_impl.cc:45: void ShellImpl::ConnectToApplication(mojo::URLRequestPtr app_url, On 2015/05/20 21:17:05, Ben Goodger (Google) ...
5 years, 7 months ago (2015-05-21 00:41:09 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121783003/320001
5 years, 7 months ago (2015-05-21 00:41:50 UTC) #22
commit-bot: I haz the power
Committed patchset #9 (id:320001)
5 years, 7 months ago (2015-05-21 00:48:23 UTC) #23
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 00:49:13 UTC) #24
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/3cf73ae56fd339f5ce180ab39a0f6dd3e5aa4b1d
Cr-Commit-Position: refs/heads/master@{#330864}

Powered by Google App Engine
This is Rietveld 408576698