Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: components/view_manager/public/cpp/lib/view_manager_client_impl.cc

Issue 1121783003: Move navigations with POST or referrer to the shell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/view_manager/public/cpp/lib/view_manager_client_impl.cc
diff --git a/components/view_manager/public/cpp/lib/view_manager_client_impl.cc b/components/view_manager/public/cpp/lib/view_manager_client_impl.cc
index 5938c9a7d02efb033af9552b2fc32cc2adb5be03..841291a2d4f0ca5865e5be6e3e10dc4773e30b27 100644
--- a/components/view_manager/public/cpp/lib/view_manager_client_impl.cc
+++ b/components/view_manager/public/cpp/lib/view_manager_client_impl.cc
@@ -192,16 +192,18 @@ void ViewManagerClientImpl::SetProperty(
}
void ViewManagerClientImpl::Embed(const String& url, Id view_id) {
- Embed(url, view_id, nullptr, nullptr);
+ mojo::URLRequestPtr request(mojo::URLRequest::New());
+ request->url = mojo::String::From(url);
+ Embed(request.Pass(), view_id, nullptr, nullptr);
}
-void ViewManagerClientImpl::Embed(const String& url,
+void ViewManagerClientImpl::Embed(mojo::URLRequestPtr request,
Id view_id,
InterfaceRequest<ServiceProvider> services,
ServiceProviderPtr exposed_services) {
DCHECK(service_);
- service_->EmbedUrl(url, view_id, services.Pass(), exposed_services.Pass(),
- ActionCompletedCallback());
+ service_->EmbedRequest(request.Pass(), view_id, services.Pass(),
+ exposed_services.Pass(), ActionCompletedCallback());
}
void ViewManagerClientImpl::Embed(Id view_id, ViewManagerClientPtr client) {

Powered by Google App Engine
This is Rietveld 408576698