Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1357)

Issue 1121643002: Modify the NaCL GN toolchains to force component build off. (Closed)

Created:
5 years, 7 months ago by Dirk Pranke
Modified:
5 years, 7 months ago
Reviewers:
bbudge, brettw
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Modify the NaCL GN toolchains to force component build off. Since the NaCl toolchains don't actually support shared libraries, we force the GN toolchain definitions to turn is_component_build off, so that regardless of the user's settings for non-NaCl toolchains, things will build correctly. R=bbudge@chromium.org, brettw@chromium.org BUG=482415 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/301048e09664d30719af473361a1d735fb840393

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M build/toolchain/gcc_toolchain.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M build/toolchain/nacl_toolchain.gni View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Dirk Pranke
5 years, 7 months ago (2015-05-01 00:24:21 UTC) #1
brettw
lgtm
5 years, 7 months ago (2015-05-01 01:09:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121643002/1
5 years, 7 months ago (2015-05-01 01:17:56 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-01 01:17:57 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121643002/1
5 years, 7 months ago (2015-05-01 01:19:16 UTC) #8
commit-bot: I haz the power
Dry run: No LGTM from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 7 months ago (2015-05-01 01:19:19 UTC) #10
bbudge
lgtm
5 years, 7 months ago (2015-05-01 21:33:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121643002/1
5 years, 7 months ago (2015-05-01 21:51:22 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: nacl-precise_64-newlib-arm_qemu-pnacl on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-arm_qemu-pnacl/builds/3922)
5 years, 7 months ago (2015-05-01 22:53:35 UTC) #15
Dirk Pranke
5 years, 7 months ago (2015-05-05 20:34:59 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
301048e09664d30719af473361a1d735fb840393 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698