build/toolchain/nacl_toolchain.gni - Issue 1121643002: Modify the NaCL GN toolchains to force component build off.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/nacl_toolchain.gni

Issue 1121643002: Modify the NaCL GN toolchains to force component build off. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/toolchain/nacl_toolchain.gni

diff --git a/build/toolchain/nacl_toolchain.gni b/build/toolchain/nacl_toolchain.gni

index cbe8e3d029b6772cb218a2689fb10596f3c56fbd..f5b961424f8dee9d7d33c2f64d3003edc3cd227d 100644

--- a/build/toolchain/nacl_toolchain.gni

+++ b/build/toolchain/nacl_toolchain.gni

@@ -43,6 +43,10 @@ template("nacl_toolchain") {

ar = invoker.ar

ld = invoker.ld

+ # NaCl toolchains do not support shared libraries and so they don't support

+ # component_mode builds.

+ is_component_build = false

gcc_toolchain(target_name) {

rebuild_define = "NACL_TC_REV=" + invoker.toolchain_revision

if (defined(invoker.deps)) {

« no previous file with comments | « build/toolchain/gcc_toolchain.gni ('k') | no next file » | no next file with comments »