Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 112163002: Fixing Java style errors in net/android/ (Closed)

Created:
7 years ago by aurimas (slooooooooow)
Modified:
7 years ago
Reviewers:
Philippe
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Fixing Java style errors in net/android/ BUG=320711 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240132

Patch Set 1 #

Patch Set 2 : update known findbugs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -69 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/android/java/src/org/chromium/net/AndroidKeyStore.java View 1 chunk +1 line, -1 line 0 comments Download
M net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java View 8 chunks +25 lines, -25 lines 0 comments Download
M net/android/java/src/org/chromium/net/GURLUtils.java View 1 chunk +1 line, -1 line 0 comments Download
M net/android/java/src/org/chromium/net/NetworkChangeNotifier.java View 1 chunk +1 line, -1 line 0 comments Download
M net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java View 4 chunks +6 lines, -6 lines 0 comments Download
M net/android/java/src/org/chromium/net/ProxyChangeListener.java View 6 chunks +12 lines, -10 lines 0 comments Download
M net/android/java/src/org/chromium/net/X509Util.java View 4 chunks +8 lines, -4 lines 0 comments Download
M net/android/javatests/src/org/chromium/net/AndroidKeyStoreTestUtil.java View 3 chunks +3 lines, -4 lines 0 comments Download
M net/android/javatests/src/org/chromium/net/AndroidProxySelectorTest.java View 3 chunks +12 lines, -9 lines 0 comments Download
M net/android/javatests/src/org/chromium/net/NetErrorsTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
M net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java View 1 chunk +1 line, -1 line 0 comments Download
M net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aurimas (slooooooooow)
Hey Philippe, Could you please take a look at this CL? Thanks, Aurimas
7 years ago (2013-12-10 23:23:17 UTC) #1
Philippe
lgtm, thanks for the cleanup Aurimas!
7 years ago (2013-12-11 08:30:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/112163002/20001
7 years ago (2013-12-11 18:28:03 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-11 18:30:12 UTC) #4
Message was sent while issue was closed.
Change committed as 240132

Powered by Google App Engine
This is Rietveld 408576698