net/android/javatests/src/org/chromium/net/AndroidKeyStoreTestUtil.java - Issue 112163002: Fixing Java style errors in net/android/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/android/javatests/src/org/chromium/net/AndroidKeyStoreTestUtil.java

Issue 112163002: Fixing Java style errors in net/android/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update known findbugs Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/android/java/src/org/chromium/net/X509Util.java ('k') | net/android/javatests/src/org/chromium/net/AndroidProxySelectorTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/android/javatests/src/org/chromium/net/AndroidKeyStoreTestUtil.java

diff --git a/net/android/javatests/src/org/chromium/net/AndroidKeyStoreTestUtil.java b/net/android/javatests/src/org/chromium/net/AndroidKeyStoreTestUtil.java

index 58dd26a5f4f5b577ed367d2f0b00f2d3eed5bb95..ab832c98a9f4567082270bf3d716b58a5a2cea61 100644

--- a/net/android/javatests/src/org/chromium/net/AndroidKeyStoreTestUtil.java

+++ b/net/android/javatests/src/org/chromium/net/AndroidKeyStoreTestUtil.java

@@ -1,4 +1,4 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

@@ -28,8 +28,7 @@ public class AndroidKeyStoreTestUtil {

* @return new PrivateKey handle, or null in case of error.

@CalledByNative

- public static PrivateKey createPrivateKeyFromPKCS8(int type,

- byte[] encoded_key) {

+ public static PrivateKey createPrivateKeyFromPKCS8(int type, byte[] encodedKey) {

String algorithm = null;

switch (type) {

case PrivateKeyType.RSA:

@@ -47,7 +46,7 @@ public class AndroidKeyStoreTestUtil {

try {

KeyFactory factory = KeyFactory.getInstance(algorithm);

- KeySpec ks = new PKCS8EncodedKeySpec(encoded_key);

+ KeySpec ks = new PKCS8EncodedKeySpec(encodedKey);

PrivateKey key = factory.generatePrivate(ks);

return key;