|
GN Windows component build fixes
The main thing this fixes is the midi component. Previously midi_unittests was never compiled on any Windows component bot and the component build was all messed up. This patch makes the component build work correctly for this component.
Remove installer_util_unittests.rc and its header. These seem to be autogenerated Visual Studio files. They just include the strings resource file, but GN includes the strings resource file itself by nature of the dependencies (GYP doesn't do this).
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg
BUG= 470212
Committed: https://crrev.com/51d04a1d341fe739beaff1528095f025a66f3fcc
Cr-Commit-Position: refs/heads/master@{#328383}
Total comments: 3
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+151 lines, -189 lines) |
Patch |
|
M |
chrome/app_installer/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_installer.gypi
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/installer/util/BUILD.gn
|
View
|
1
2
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
D |
chrome/installer/util/installer_util_unittests.rc
|
View
|
|
1 chunk |
+0 lines, -72 lines |
0 comments
|
Download
|
|
D |
chrome/installer/util/installer_util_unittests_resource.h
|
View
|
|
1 chunk |
+0 lines, -18 lines |
0 comments
|
Download
|
|
M |
chrome/test/BUILD.gn
|
View
|
1
2
3
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/test/BUILD.gn
|
View
|
|
5 chunks |
+3 lines, -25 lines |
0 comments
|
Download
|
|
M |
media/midi/BUILD.gn
|
View
|
1
2
3
|
4 chunks |
+32 lines, -31 lines |
0 comments
|
Download
|
|
M |
media/midi/midi.gyp
|
View
|
1
2
|
4 chunks |
+6 lines, -4 lines |
0 comments
|
Download
|
|
A |
media/midi/midi_export.h
|
View
|
|
1 chunk |
+29 lines, -0 lines |
0 comments
|
Download
|
|
M |
media/midi/midi_jni_registrar.h
|
View
|
1
2
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
media/midi/midi_manager.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
media/midi/midi_manager_alsa.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
media/midi/midi_manager_mac.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
media/midi/midi_manager_usb.h
|
View
|
|
2 chunks |
+6 lines, -4 lines |
0 comments
|
Download
|
|
M |
media/midi/midi_message_queue.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
media/midi/midi_message_util.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
media/midi/midi_port_info.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
media/midi/midi_scheduler.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
media/midi/usb_midi_descriptor_parser.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
media/midi/usb_midi_device.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
media/midi/usb_midi_device_android.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
media/midi/usb_midi_device_factory_android.h
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
A |
media/midi/usb_midi_export.h
|
View
|
|
1 chunk |
+33 lines, -0 lines |
0 comments
|
Download
|
|
M |
media/midi/usb_midi_input_stream.h
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
media/midi/usb_midi_jack.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
media/midi/usb_midi_output_stream.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
remoting/base/BUILD.gn
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
Total messages: 27 (12 generated)
|