Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1121363002: GN Windows component build fixes (Closed)

Created:
5 years, 7 months ago by brettw
Modified:
5 years, 7 months ago
CC:
chromium-reviews, toyoshim+midi_chromium.org, chromoting-reviews_chromium.org, grt+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@component2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN Windows component build fixes The main thing this fixes is the midi component. Previously midi_unittests was never compiled on any Windows component bot and the component build was all messed up. This patch makes the component build work correctly for this component. Remove installer_util_unittests.rc and its header. These seem to be autogenerated Visual Studio files. They just include the strings resource file, but GN includes the strings resource file itself by nature of the dependencies (GYP doesn't do this). CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg BUG=470212 Committed: https://crrev.com/51d04a1d341fe739beaff1528095f025a66f3fcc Cr-Commit-Position: refs/heads/master@{#328383}

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : . #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -189 lines) Patch
M chrome/app_installer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_installer.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/installer/util/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/installer/util/installer_util_unittests.rc View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/installer/util/installer_util_unittests_resource.h View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 5 chunks +3 lines, -25 lines 0 comments Download
M media/midi/BUILD.gn View 1 2 3 4 chunks +32 lines, -31 lines 0 comments Download
M media/midi/midi.gyp View 1 2 4 chunks +6 lines, -4 lines 0 comments Download
A media/midi/midi_export.h View 1 chunk +29 lines, -0 lines 0 comments Download
M media/midi/midi_jni_registrar.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M media/midi/midi_manager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M media/midi/midi_manager_alsa.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/midi/midi_manager_mac.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/midi/midi_manager_usb.h View 2 chunks +6 lines, -4 lines 0 comments Download
M media/midi/midi_message_queue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/midi/midi_message_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/midi/midi_port_info.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/midi/midi_scheduler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/midi/usb_midi_descriptor_parser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/midi/usb_midi_device.h View 3 chunks +3 lines, -3 lines 0 comments Download
M media/midi/usb_midi_device_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/midi/usb_midi_device_factory_android.h View 1 chunk +3 lines, -2 lines 0 comments Download
A media/midi/usb_midi_export.h View 1 chunk +33 lines, -0 lines 0 comments Download
M media/midi/usb_midi_input_stream.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/midi/usb_midi_jack.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/midi/usb_midi_output_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/base/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (12 generated)
brettw
5 years, 7 months ago (2015-05-05 00:02:28 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121363002/20001
5 years, 7 months ago (2015-05-05 00:03:54 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/67882) android_chromium_gn_compile_rel on ...
5 years, 7 months ago (2015-05-05 00:15:42 UTC) #6
scottmg
lgtm https://codereview.chromium.org/1121363002/diff/20001/chrome/installer/util/BUILD.gn File chrome/installer/util/BUILD.gn (right): https://codereview.chromium.org/1121363002/diff/20001/chrome/installer/util/BUILD.gn#newcode258 chrome/installer/util/BUILD.gn:258: #":strings", ? https://codereview.chromium.org/1121363002/diff/20001/media/midi/midi.gyp File media/midi/midi.gyp (right): https://codereview.chromium.org/1121363002/diff/20001/media/midi/midi.gyp#newcode61 media/midi/midi.gyp:61: ...
5 years, 7 months ago (2015-05-05 01:46:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121363002/40001
5 years, 7 months ago (2015-05-05 16:36:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/68110)
5 years, 7 months ago (2015-05-05 16:49:14 UTC) #12
brettw
.
5 years, 7 months ago (2015-05-05 17:10:08 UTC) #13
brettw
.
5 years, 7 months ago (2015-05-05 17:11:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121363002/100001
5 years, 7 months ago (2015-05-05 17:13:25 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/64004)
5 years, 7 months ago (2015-05-05 17:19:21 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121363002/100001
5 years, 7 months ago (2015-05-05 17:38:56 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121363002/100001
5 years, 7 months ago (2015-05-05 18:25:29 UTC) #24
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 7 months ago (2015-05-05 19:43:13 UTC) #25
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/51d04a1d341fe739beaff1528095f025a66f3fcc Cr-Commit-Position: refs/heads/master@{#328383}
5 years, 7 months ago (2015-05-05 19:44:33 UTC) #26
Takashi Toyoshima
5 years, 7 months ago (2015-05-08 03:44:56 UTC) #27
Message was sent while issue was closed.
lgtm.
thank you for fixing this.

Powered by Google App Engine
This is Rietveld 408576698