Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4213)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/chrome_installer.gypi

Issue 1121363002: GN Windows component build fixes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@component2
Patch Set: . Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app_installer/BUILD.gn ('k') | chrome/installer/util/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_installer.gypi
diff --git a/chrome/chrome_installer.gypi b/chrome/chrome_installer.gypi
index ca2ae2f00509600186eabc893a246e3f8b190642..80763c3e1222c1a656f0abe8575b0395f070fe77 100644
--- a/chrome/chrome_installer.gypi
+++ b/chrome/chrome_installer.gypi
@@ -97,6 +97,7 @@
'sources': [
# List duplicated in GN build.
'<(SHARED_INTERMEDIATE_DIR)/chrome_version/other_version.rc',
+ '<(SHARED_INTERMEDIATE_DIR)/chrome/installer/util/installer_util_strings.rc',
'installer/setup/compat_checks_unittest.cc',
'installer/setup/setup_constants.cc',
'installer/util/advanced_firewall_manager_win_unittest.cc',
@@ -120,8 +121,6 @@
'installer/util/installer_state_unittest.cc',
'installer/util/installer_util_test_common.cc',
'installer/util/installer_util_test_common.h',
- 'installer/util/installer_util_unittests.rc',
- 'installer/util/installer_util_unittests_resource.h',
'installer/util/language_selector_unittest.cc',
'installer/util/legacy_firewall_manager_win_unittest.cc',
'installer/util/logging_installer_unittest.cc',
« no previous file with comments | « chrome/app_installer/BUILD.gn ('k') | chrome/installer/util/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698