Added unittest for ui/gl.

Added unittest for ui/gl.

This CL adds a unit testing harness for ui/gl tests.

In order to ensure that the bots do not break once they start running
these unit tests, gl_unittests currently it does not run any tests.
Once the bots successfully run gl_unittests, we can safely add tests
using the trybots to make sure the added tests actually work.

R=danakj@chromium.org, sievers@chromium.org
BUG=482067
Committed: https://crrev.com/781489a282f6f7e19d7d449500cd2e91b2bc46a5
Cr-Commit-Position: refs/heads/master@{#328407}

[David Yen, 2015-05-05 19:05:30]

Once this lands, I will make a change in the tools/build repo for the bots to
run the unit test.

Once that is done, I will move the gl_api_unittest to gl_unittests.

For reference, gl_api_unittest is found here:
https://codereview.chromium.org/1110923003/

Does anyone know who I should include to review the root gyp/gn files?

[no sievers, 2015-05-05 19:13:27]

sievers@chromium.org changed reviewers:
+ dpranke@chromium.org

[no sievers, 2015-05-05 19:14:11]

Nice.

+dpranke for root buildfile changes.

https://codereview.chromium.org/1121353002/diff/60001/ui/gl/gl_tests.gyp
File ui/gl/gl_tests.gyp (right):

https://codereview.chromium.org/1121353002/diff/60001/ui/gl/gl_tests.gyp#newc...
ui/gl/gl_tests.gyp:17: '../../base/base.gyp:base',
nit: Can you use <(DEPTH)/base etc. here and everywhere below?

https://codereview.chromium.org/1121353002/diff/60001/ui/gl/gl_unittests.isolate
File ui/gl/gl_unittests.isolate (right):

https://codereview.chromium.org/1121353002/diff/60001/ui/gl/gl_unittests.isol...
ui/gl/gl_unittests.isolate:1: # Copyright (c) 2014 The Chromium Authors. All
rights reserved.
nit: 'Copyright 2015'

[David Yen, 2015-05-05 19:20:17]

https://codereview.chromium.org/1121353002/diff/60001/ui/gl/gl_tests.gyp
File ui/gl/gl_tests.gyp (right):

https://codereview.chromium.org/1121353002/diff/60001/ui/gl/gl_tests.gyp#newc...
ui/gl/gl_tests.gyp:17: '../../base/base.gyp:base',
On 2015/05/05 19:14:10, sievers wrote:
> nit: Can you use <(DEPTH)/base etc. here and everywhere below?

Done.

https://codereview.chromium.org/1121353002/diff/60001/ui/gl/gl_unittests.isolate
File ui/gl/gl_unittests.isolate (right):

https://codereview.chromium.org/1121353002/diff/60001/ui/gl/gl_unittests.isol...
ui/gl/gl_unittests.isolate:1: # Copyright (c) 2014 The Chromium Authors. All
rights reserved.
On 2015/05/05 19:14:10, sievers wrote:
> nit: 'Copyright 2015'

Done.

[no sievers, 2015-05-05 19:23:45]

lgtm. But can you double-check that it triggers running the suite on all
platforms incl. Android when the trybots finish?

https://codereview.chromium.org/1121353002/diff/80001/ui/gl/gl_tests.gyp
File ui/gl/gl_tests.gyp (right):

https://codereview.chromium.org/1121353002/diff/80001/ui/gl/gl_tests.gyp#newc...
ui/gl/gl_tests.gyp:42: 'includes': [ '../../build/apk_test.gypi' ],
Does <(DEPTH) work here too and in line 55?

https://codereview.chromium.org/1121353002/diff/80001/ui/gl/gl_unittests.isolate
File ui/gl/gl_unittests.isolate (right):

https://codereview.chromium.org/1121353002/diff/80001/ui/gl/gl_unittests.isol...
ui/gl/gl_unittests.isolate:1: # Copyright (c) 2015 The Chromium Authors. All
rights reserved.
nit: drop the (c)

[David Yen, 2015-05-05 19:37:31]

https://codereview.chromium.org/1121353002/diff/80001/ui/gl/gl_tests.gyp
File ui/gl/gl_tests.gyp (right):

https://codereview.chromium.org/1121353002/diff/80001/ui/gl/gl_tests.gyp#newc...
ui/gl/gl_tests.gyp:42: 'includes': [ '../../build/apk_test.gypi' ],
On 2015/05/05 19:23:45, sievers wrote:
> Does <(DEPTH) work here too and in line 55?

I think it only works in dependencies not includes (at least it didn't for me
locally). Probably just the way gyp parses includes.

https://codereview.chromium.org/1121353002/diff/80001/ui/gl/gl_unittests.isolate
File ui/gl/gl_unittests.isolate (right):

https://codereview.chromium.org/1121353002/diff/80001/ui/gl/gl_unittests.isol...
ui/gl/gl_unittests.isolate:1: # Copyright (c) 2015 The Chromium Authors. All
rights reserved.
On 2015/05/05 19:23:45, sievers wrote:
> nit: drop the (c)

I think they all have the (c), the one on the left here is the incorrect one.

[Dirk Pranke, 2015-05-05 19:37:55]

lgtm

[David Yen, 2015-05-05 19:39:03]

On 2015/05/05 19:23:45, sievers wrote:
> lgtm. But can you double-check that it triggers running the suite on all
> platforms incl. Android when the trybots finish?

It shouldn't be running until I change the bots and regenerate the expectations.

[no sievers, 2015-05-05 19:42:49]

https://codereview.chromium.org/1121353002/diff/80001/ui/gl/gl_unittests.isolate
File ui/gl/gl_unittests.isolate (right):

https://codereview.chromium.org/1121353002/diff/80001/ui/gl/gl_unittests.isol...
ui/gl/gl_unittests.isolate:1: # Copyright (c) 2015 The Chromium Authors. All
rights reserved.
On 2015/05/05 19:37:31, David Yen wrote:
> On 2015/05/05 19:23:45, sievers wrote:
> > nit: drop the (c)
> 
> I think they all have the (c), the one on the left here is the incorrect one.

The new header format dropped the (c), see
https://www.chromium.org/developers/coding-style

[David Yen, 2015-05-05 19:45:01]

https://codereview.chromium.org/1121353002/diff/80001/ui/gl/gl_unittests.isolate
File ui/gl/gl_unittests.isolate (right):

https://codereview.chromium.org/1121353002/diff/80001/ui/gl/gl_unittests.isol...
ui/gl/gl_unittests.isolate:1: # Copyright (c) 2015 The Chromium Authors. All
rights reserved.
On 2015/05/05 19:42:49, sievers wrote:
> On 2015/05/05 19:37:31, David Yen wrote:
> > On 2015/05/05 19:23:45, sievers wrote:
> > > nit: drop the (c)
> > 
> > I think they all have the (c), the one on the left here is the incorrect
one.
> 
> The new header format dropped the (c), see
> https://www.chromium.org/developers/coding-style

Oh, I see. Done.

[David Yen, 2015-05-05 20:53:02]

The CQ bit was checked by dyen@chromium.org

[David Yen, 2015-05-05 20:53:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1121353002/#ps100001
(title: "Removed (c)")

[commit-bot: I haz the power, 2015-05-05 20:53:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1121353002/100001

[commit-bot: I haz the power, 2015-05-05 21:41:10]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-05-05 21:42:58]

Patchset 6 (id:??) landed as
https://crrev.com/781489a282f6f7e19d7d449500cd2e91b2bc46a5
Cr-Commit-Position: refs/heads/master@{#328407}