ui/gl/gl_unittests.isolate - Issue 1121353002: Added unittest for ui/gl.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gl/gl_unittests.isolate

Issue 1121353002: Added unittest for ui/gl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use <(DEPTH) for dependencies Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2015 The Chromium Authors. All rights reserved.
	no sievers 2015/05/05 19:23:45 nit: drop the (c) nit: drop the (c) David Yen 2015/05/05 19:37:31 I think they all have the (c), the one on the left Show quoted text On 2015/05/05 19:23:45, sievers wrote: > nit: drop the (c) I think they all have the (c), the one on the left here is the incorrect one. no sievers 2015/05/05 19:42:49 The new header format dropped the (c), see https:/ Show quoted text On 2015/05/05 19:37:31, David Yen wrote: > On 2015/05/05 19:23:45, sievers wrote: > > nit: drop the (c) > > I think they all have the (c), the one on the left here is the incorrect one. The new header format dropped the (c), see https://www.chromium.org/developers/coding-style David Yen 2015/05/05 19:45:01 Oh, I see. Done. Show quoted text On 2015/05/05 19:42:49, sievers wrote: > On 2015/05/05 19:37:31, David Yen wrote: > > On 2015/05/05 19:23:45, sievers wrote: > > > nit: drop the (c) > > > > I think they all have the (c), the one on the left here is the incorrect one. > > The new header format dropped the (c), see > https://www.chromium.org/developers/coding-style Oh, I see. Done.
2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 {	4 {

5 'includes': [

6 '../base/base.isolate',

7 '../third_party/angle/angle.isolate',

8 ],

9 'conditions': [	5 'conditions': [

10 ['OS=="android" or OS=="linux" or OS=="mac" or OS=="win"', {	6 ['OS=="android" or OS=="linux" or OS=="mac" or OS=="win"', {

11 'variables': {	7 'variables': {

12 'command': [	8 'command': [

13 '<(PRODUCT_DIR)/gl_tests<(EXECUTABLE_SUFFIX)',	9 '<(PRODUCT_DIR)/gl_unittests<(EXECUTABLE_SUFFIX)',

14 ],	10 ],

15 'files': [	11 'files': [

16 '<(PRODUCT_DIR)/gl_tests<(EXECUTABLE_SUFFIX)',	12 '<(PRODUCT_DIR)/gl_unittests<(EXECUTABLE_SUFFIX)',

17 ],	13 ],

18 },	14 },

19 }],	15 }],

20 ],	16 ],

	17 'includes': [

	18 '../../base/base.isolate',

	19 ],

21 }	20 }

OLD	NEW

« ui/gl/gl_tests.gyp ('K') | « ui/gl/gl_tests.gyp ('k') | ui/gl/test/run_all_unittests.cc » ('j') | no next file with comments »