Add Accept-CH meta http-equiv support to the preloader.

Add Accept-CH meta http-equiv support to the preloader.

When "Accept-CH" is provided as a meta tag, in some cases the parser doesn't get to parsing it before the preloader parses out image resources and send their requests.
This CL fixes that, by adding these parsing capabilities to the HTMLPreloadScanner, and enables it to add the CH preference to the PreloadRequest and the FetchRequest objects.

BUG=482840
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194941

[Yoav Weiss, 2015-05-05 07:07:13]

yoav@yoav.ws changed reviewers:
+ japhet@chromium.org, mkwst@chromium.org

[Yoav Weiss, 2015-05-05 07:07:48]

yoav@yoav.ws changed reviewers:
+ kouhei@chromium.org

[Mike West, 2015-05-05 15:22:37]

LGTM % nits.

https://codereview.chromium.org/1121263002/diff/40001/Source/core/html/parser...
File Source/core/html/parser/HTMLPreloadScannerTest.cpp (right):

https://codereview.chromium.org/1121263002/diff/40001/Source/core/html/parser...
Source/core/html/parser/HTMLPreloadScannerTest.cpp:148: for (auto testCase:
testCases)
Nit: s/testCase: /testCase : /

https://codereview.chromium.org/1121263002/diff/40001/Source/core/html/parser...
Source/core/html/parser/HTMLPreloadScannerTest.cpp:172: for (auto testCase:
testCases)
Nit: Ditto.

https://codereview.chromium.org/1121263002/diff/40001/Source/core/html/parser...
File Source/core/html/parser/PreloadRequest.h (right):

https://codereview.chromium.org/1121263002/diff/40001/Source/core/html/parser...
Source/core/html/parser/PreloadRequest.h:46: const FetchRequest::ResourceWidth&
resourceWidth, const ClientHintsPreferences& clientHintsPreferences)
Nit: This is somewhat strange line-breaking.

https://codereview.chromium.org/1121263002/diff/40001/Source/core/loader/Fram...
File Source/core/loader/FrameFetchContext.cpp (right):

https://codereview.chromium.org/1121263002/diff/40001/Source/core/loader/Fram...
Source/core/loader/FrameFetchContext.cpp:619: if
(m_document->clientHintsPreferences().shouldSendDPR() ||
fetchRequest.clientHintsPreferences().shouldSendDPR())
I'd suggest extracting this into a `shouldSendDPR` boolean variable, and reusing
it here and below for clarity.

[Yoav Weiss, 2015-05-05 16:19:44]

On 2015/05/05 15:22:37, Mike West (traveling. slow.) wrote:
> LGTM % nits.
> 
>
https://codereview.chromium.org/1121263002/diff/40001/Source/core/html/parser...
> File Source/core/html/parser/HTMLPreloadScannerTest.cpp (right):
> 
>
https://codereview.chromium.org/1121263002/diff/40001/Source/core/html/parser...
> Source/core/html/parser/HTMLPreloadScannerTest.cpp:148: for (auto testCase:
> testCases)
> Nit: s/testCase: /testCase : /
> 
>
https://codereview.chromium.org/1121263002/diff/40001/Source/core/html/parser...
> Source/core/html/parser/HTMLPreloadScannerTest.cpp:172: for (auto testCase:
> testCases)
> Nit: Ditto.
> 
>
https://codereview.chromium.org/1121263002/diff/40001/Source/core/html/parser...
> File Source/core/html/parser/PreloadRequest.h (right):
> 
>
https://codereview.chromium.org/1121263002/diff/40001/Source/core/html/parser...
> Source/core/html/parser/PreloadRequest.h:46: const
FetchRequest::ResourceWidth&
> resourceWidth, const ClientHintsPreferences& clientHintsPreferences)
> Nit: This is somewhat strange line-breaking.
> 
>
https://codereview.chromium.org/1121263002/diff/40001/Source/core/loader/Fram...
> File Source/core/loader/FrameFetchContext.cpp (right):
> 
>
https://codereview.chromium.org/1121263002/diff/40001/Source/core/loader/Fram...
> Source/core/loader/FrameFetchContext.cpp:619: if
> (m_document->clientHintsPreferences().shouldSendDPR() ||
> fetchRequest.clientHintsPreferences().shouldSendDPR())
> I'd suggest extracting this into a `shouldSendDPR` boolean variable, and
reusing
> it here and below for clarity.

Done :)

[Yoav Weiss, 2015-05-05 18:31:18]

The CQ bit was checked by yoav@yoav.ws

[Yoav Weiss, 2015-05-05 18:31:19]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1121263002/#ps60001
(title: "Review nits")

[commit-bot: I haz the power, 2015-05-05 18:32:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1121263002/60001

[commit-bot: I haz the power, 2015-05-05 21:07:02]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194941