Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Unified Diff: Source/core/html/parser/HTMLPreloadScannerTest.cpp

Issue 1121263002: Add Accept-CH meta http-equiv support to the preloader. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review nits Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/parser/HTMLPreloadScanner.cpp ('k') | Source/core/html/parser/PreloadRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/parser/HTMLPreloadScannerTest.cpp
diff --git a/Source/core/html/parser/HTMLPreloadScannerTest.cpp b/Source/core/html/parser/HTMLPreloadScannerTest.cpp
index d696a225adf49cf04ee93de7734f4ab6bb7d06dc..b6caafef48c30af691ec18f58e0808e196185f67 100644
--- a/Source/core/html/parser/HTMLPreloadScannerTest.cpp
+++ b/Source/core/html/parser/HTMLPreloadScannerTest.cpp
@@ -7,6 +7,7 @@
#include "core/MediaTypeNames.h"
#include "core/css/MediaValuesCached.h"
+#include "core/fetch/ClientHintsPreferences.h"
#include "core/html/parser/HTMLParserOptions.h"
#include "core/html/parser/HTMLResourcePreloader.h"
#include "core/testing/DummyPageHolder.h"
@@ -21,6 +22,7 @@ typedef struct {
const char* outputBaseURL;
Resource::Type type;
int resourceWidth;
+ ClientHintsPreferences preferences;
} TestCase;
class MockHTMLResourcePreloader : public ResourcePreloader {
@@ -110,9 +112,10 @@ TEST_F(HTMLPreloadScannerTest, testImages)
{"http://example.test", "<img srcset='bla2.gif 100w, bla3.gif 250w, bla4.gif 500w' sizes='50vw' src='bla.gif'>", "bla4.gif", "http://example.test/", Resource::Image, 250},
};
- for (auto testCase: testCases)
+ for (auto testCase : testCases)
test(testCase);
}
+
TEST_F(HTMLPreloadScannerTest, testImagesWithViewport)
{
TestCase testCases[] = {
@@ -131,7 +134,42 @@ TEST_F(HTMLPreloadScannerTest, testImagesWithViewport)
{"http://example.test", "<img srcset='bla2.gif 160w, bla3.gif 250w, bla4.gif 500w' sizes='50vw' src='bla.gif'>", "bla2.gif", "http://example.test/", Resource::Image, 80},
};
- for (auto testCase: testCases)
+ for (auto testCase : testCases)
+ test(testCase);
+}
+
+TEST_F(HTMLPreloadScannerTest, testViewportNoContent)
+{
+ TestCase testCases[] = {
+ {"http://example.test", "<meta name=viewport><img srcset='bla.gif 320w, blabla.gif 640w'>", "blabla.gif", "http://example.test/", Resource::Image, 0},
+ {"http://example.test", "<meta name=viewport content=sdkbsdkjnejjha><img srcset='bla.gif 320w, blabla.gif 640w'>", "blabla.gif", "http://example.test/", Resource::Image, 0},
+ };
+
+ for (auto testCase : testCases)
+ test(testCase);
+}
+
+TEST_F(HTMLPreloadScannerTest, testMetaAcceptCH)
+{
+ ClientHintsPreferences dpr;
+ ClientHintsPreferences rw;
+ ClientHintsPreferences dprAndRw;
+ dpr.setShouldSendDPR(true);
+ dprAndRw.setShouldSendDPR(true);
+ rw.setShouldSendRW(true);
+ dprAndRw.setShouldSendRW(true);
+ TestCase testCases[] = {
+ {"http://example.test", "<meta http-equiv='accept-ch' content='bla'><img srcset='bla.gif 320w, blabla.gif 640w'>", "blabla.gif", "http://example.test/", Resource::Image, 0},
+ {"http://example.test", "<meta http-equiv='accept-ch' content='dprw'><img srcset='bla.gif 320w, blabla.gif 640w'>", "blabla.gif", "http://example.test/", Resource::Image, 0},
+ {"http://example.test", "<meta http-equiv='accept-ch'><img srcset='bla.gif 320w, blabla.gif 640w'>", "blabla.gif", "http://example.test/", Resource::Image, 0},
+ {"http://example.test", "<meta http-equiv='accept-ch' content='dpr \t'><img srcset='bla.gif 320w, blabla.gif 640w'>", "blabla.gif", "http://example.test/", Resource::Image, 0, dpr},
+ {"http://example.test", "<meta http-equiv='accept-ch' content='bla,dpr \t'><img srcset='bla.gif 320w, blabla.gif 640w'>", "blabla.gif", "http://example.test/", Resource::Image, 0, dpr},
+ {"http://example.test", "<meta http-equiv='accept-ch' content=' rw '><img srcset='bla.gif 320w, blabla.gif 640w'>", "blabla.gif", "http://example.test/", Resource::Image, 0, rw},
+ {"http://example.test", "<meta http-equiv='accept-ch' content=' rw , wutever'><img srcset='bla.gif 320w, blabla.gif 640w'>", "blabla.gif", "http://example.test/", Resource::Image, 0, rw},
+ {"http://example.test", "<meta http-equiv='accept-ch' content=' rw , wutever, dpr \t'><img srcset='bla.gif 320w, blabla.gif 640w'>", "blabla.gif", "http://example.test/", Resource::Image, 0, dprAndRw},
+ };
+
+ for (auto testCase : testCases)
test(testCase);
}
« no previous file with comments | « Source/core/html/parser/HTMLPreloadScanner.cpp ('k') | Source/core/html/parser/PreloadRequest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698