Don't adjust deadline for children BeginFrames

Don't adjust deadline for children BeginFrames

This isn't needed anymore since we have Surfaces
on all platforms where we use a cc::Scheduler in
the Browser, which enabled commitless updates
for the Renderers. i.e. the Browser's commit
is no longer in the critical path of the
Renderer's swap.

BUG=372086
Committed: https://crrev.com/7d4d98d5dfc5b2e6d8dff83954b9302d1a5d60d5
Cr-Commit-Position: refs/heads/master@{#328265}

[brianderson, 2015-05-05 00:53:08]

brianderson@chromium.org changed reviewers:
+ simonhong@chromium.org, sunnyps@chromium.org

[brianderson, 2015-05-05 00:53:09]

Noticed a small incompatibility with the recent landing of unified BeginFrame
patch and Surfaces.

ptal

[sunnyps, 2015-05-05 01:00:42]

https://codereview.chromium.org/1121233005/diff/1/cc/scheduler/scheduler.cc
File cc/scheduler/scheduler.cc (right):

https://codereview.chromium.org/1121233005/diff/1/cc/scheduler/scheduler.cc#n...
cc/scheduler/scheduler.cc:348:
client_->SendBeginFramesToChildren(adjusted_args);
Can you add a TODO get rid of this deadline adjustment too? Ideally the display
scheduler should decide what the deadline for a given client is.

https://codereview.chromium.org/1121233005/diff/1/cc/scheduler/scheduler_unit...
File cc/scheduler/scheduler_unittest.cc (right):

https://codereview.chromium.org/1121233005/diff/1/cc/scheduler/scheduler_unit...
cc/scheduler/scheduler_unittest.cc:476:
EXPECT_EQ(client_->begin_frame_args_sent_to_children().deadline,
I don't think this is test works. This would hold even before the change because
the estimates (main frame, draw, parent draw) are all zero.

[brianderson, 2015-05-05 01:53:29]

https://codereview.chromium.org/1121233005/diff/1/cc/scheduler/scheduler.cc
File cc/scheduler/scheduler.cc (right):

https://codereview.chromium.org/1121233005/diff/1/cc/scheduler/scheduler.cc#n...
cc/scheduler/scheduler.cc:348:
client_->SendBeginFramesToChildren(adjusted_args);
On 2015/05/05 01:00:41, sunnyps wrote:
> Can you add a TODO get rid of this deadline adjustment too? Ideally the
display
> scheduler should decide what the deadline for a given client is.

Done.

https://codereview.chromium.org/1121233005/diff/1/cc/scheduler/scheduler_unit...
File cc/scheduler/scheduler_unittest.cc (right):

https://codereview.chromium.org/1121233005/diff/1/cc/scheduler/scheduler_unit...
cc/scheduler/scheduler_unittest.cc:476:
EXPECT_EQ(client_->begin_frame_args_sent_to_children().deadline,
On 2015/05/05 01:00:42, sunnyps wrote:
> I don't think this is test works. This would hold even before the change
because
> the estimates (main frame, draw, parent draw) are all zero.

Good catch. It didn't fail without this patch. I changed it to use
SchedulerClientWithFixedEstimates so it fails without this patch now.

[sunnyps, 2015-05-05 01:58:34]

LGTM

[brianderson, 2015-05-05 02:08:19]

The CQ bit was checked by brianderson@chromium.org

[commit-bot: I haz the power, 2015-05-05 02:09:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1121233005/20001

[commit-bot: I haz the power, 2015-05-05 03:24:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-05 03:25:26]

Patchset 2 (id:??) landed as
https://crrev.com/7d4d98d5dfc5b2e6d8dff83954b9302d1a5d60d5
Cr-Commit-Position: refs/heads/master@{#328265}