Source/core/html/canvas/WebGLRenderingContextBase.h - Issue 1120953002: WebGL 2: add read/write framebuffer binding points to related APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/WebGLRenderingContextBase.h

Issue 1120953002: WebGL 2: add read/write framebuffer binding points to related APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed zmo@'s feedback: WebGLFramebuffer::isBound need to be updated Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/canvas/WebGLFramebuffer.cpp ('K') | « Source/core/html/canvas/WebGLFramebuffer.cpp ('k') | Source/core/html/canvas/WebGLRenderingContextBase.cpp » ('j') | Source/core/html/canvas/WebGLRenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/canvas/WebGLRenderingContextBase.h

diff --git a/Source/core/html/canvas/WebGLRenderingContextBase.h b/Source/core/html/canvas/WebGLRenderingContextBase.h

index f8e72ae00baa8859f1fd7fac8676a9e73fa36e94..0f6d7275e4c260c67cdaff6525afe92277df88d8 100644

--- a/Source/core/html/canvas/WebGLRenderingContextBase.h

+++ b/Source/core/html/canvas/WebGLRenderingContextBase.h

@@ -165,7 +165,7 @@ public:

void cullFace(GLenum mode);

void deleteBuffer(WebGLBuffer*);

- void deleteFramebuffer(WebGLFramebuffer*);

+ virtual void deleteFramebuffer(WebGLFramebuffer*);

void deleteProgram(WebGLProgram*);

void deleteRenderbuffer(WebGLRenderbuffer*);

void deleteShader(WebGLShader*);

@@ -776,7 +776,7 @@ protected:

bool isTexInternalFormatColorBufferCombinationValid(GLenum texInternalFormat, GLenum colorBufferFormat);

// Helper function to get the bound framebuffer's color buffer format.

- GLenum boundFramebufferColorFormat();

+ virtual GLenum boundFramebufferColorFormat();

// Helper function to verify limits on the length of uniform and attribute locations.

bool validateLocationLength(const char* functionName, const String&);

@@ -988,7 +988,7 @@ protected:

void setBackDrawBuffer(GLenum);

void setFramebuffer(GLenum, WebGLFramebuffer*);

- void restoreCurrentFramebuffer();

+ virtual void restoreCurrentFramebuffer();

void restoreCurrentTexture2D();

virtual void multisamplingChanged(bool) override;