Remove EF_FUNCTION_KEY and EF_NUMPAD_KEY.

ui/events/keycodes/dom4/keycode_converter.h

Index: ui/events/keycodes/dom4/keycode_converter.h
diff --git a/ui/events/keycodes/dom4/keycode_converter.h b/ui/events/keycodes/dom4/keycode_converter.h
index 1ed0d1231488ebf85e015d5075980b98c8d31d56..afebc03ae114d20a610873b6d360db4adf49c371 100644
--- a/ui/events/keycodes/dom4/keycode_converter.h
+++ b/ui/events/keycodes/dom4/keycode_converter.h
@@ -16,6 +16,8 @@ namespace ui {
 enum class DomCode;
 enum class DomKey;
 
+enum class DomCodeLocation { STANDARD, LEFT, RIGHT, NUMPAD };

[kpschoedel, 2015/05/01 16:13:18]

I know the spec calls these DOM_KEY_LOCATION_STANDARD, etc., but DomKeyLocation
would be confusing here because it's derived from a DomCode rather than a
DomKey.

[Wez, 2015/05/05 00:29:09]

I'd argue that DomKeyLocation is the better name, since it is a location value
that identifies which specific instance a DomKey refers to, whereas for DomCode
the location information is implicit - to convey equivalent detail to the
DomCode, a call-site should handle both a DomKey and a DomKeyLocation.

[kpschoedel, 2015/05/05 16:30:08]

Done.

+
 // This structure is used to define the keycode mapping table.
 // It is defined here because the unittests need access to it.
 typedef struct {
@@ -62,6 +64,9 @@ class KeycodeConverter {
   // Convert a DomCode into a UI Events |code| string value.
   static const char* DomCodeToCodeString(DomCode dom_code);
 
+  // Return the DomCodeLocation of a DomCode.

[Wez, 2015/05/05 00:29:09]

Suggest stating explicitly that this is used to distinguish between instances of
keys with the same meaning, and therefore the same DomKey and/or VKEY.

[kpschoedel, 2015/05/05 16:30:08]

Done.

+  static DomCodeLocation DomCodeToLocation(DomCode dom_code);
+
   // Convert a UI Events |key| string value into a DomKey.
   static DomKey KeyStringToDomKey(const char* key);