Remove EF_FUNCTION_KEY and EF_NUMPAD_KEY.

ui/events/keycodes/dom4/keycode_converter.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_EVENTS_KEYCODES_DOM4_KEYCODE_CONVERTER_H_
 #define UI_EVENTS_KEYCODES_DOM4_KEYCODE_CONVERTER_H_
 
 #include <stdint.h>
 #include "base/basictypes.h"
 
 // For reference, the W3C UI Event spec is located at:
 // http://www.w3.org/TR/uievents/
 
 namespace ui {
 
 enum class DomCode;
 enum class DomKey;
 
+enum class DomCodeLocation { STANDARD, LEFT, RIGHT, NUMPAD };

[kpschoedel, 2015/05/01 16:13:18]

I know the spec calls these DOM_KEY_LOCATION_STANDARD, etc., but DomKeyLocation
would be confusing here because it's derived from a DomCode rather than a
DomKey.

[Wez, 2015/05/05 00:29:09]

I'd argue that DomKeyLocation is the better name, since it is a location value
that identifies which specific instance a DomKey refers to, whereas for DomCode
the location information is implicit - to convey equivalent detail to the
DomCode, a call-site should handle both a DomKey and a DomKeyLocation.

[kpschoedel, 2015/05/05 16:30:08]

Done.

+
 // This structure is used to define the keycode mapping table.
 // It is defined here because the unittests need access to it.
 typedef struct {
   // USB keycode:
   //  Upper 16-bits: USB Usage Page.
   //  Lower 16-bits: USB Usage Id: Assigned ID within this usage page.
   uint32_t usb_keycode;
 
   // Contains one of the following:
   //  On Linux: XKB scancode
@@ skipping 26 matching lines @@
 
   // Convert a DomCode into a native keycode.
   static int DomCodeToNativeKeycode(DomCode code);
 
   // Convert a UI Events |code| string value into a DomCode.
   static DomCode CodeStringToDomCode(const char* code);
 
   // Convert a DomCode into a UI Events |code| string value.
   static const char* DomCodeToCodeString(DomCode dom_code);
 
+  // Return the DomCodeLocation of a DomCode.

[Wez, 2015/05/05 00:29:09]

Suggest stating explicitly that this is used to distinguish between instances of
keys with the same meaning, and therefore the same DomKey and/or VKEY.

[kpschoedel, 2015/05/05 16:30:08]

Done.

+  static DomCodeLocation DomCodeToLocation(DomCode dom_code);
+
   // Convert a UI Events |key| string value into a DomKey.
   static DomKey KeyStringToDomKey(const char* key);
 
   // Convert a DomKey into a UI Events |key| string value.
   static const char* DomKeyToKeyString(DomKey dom_key);
 
   // The following methods relate to USB keycodes.
   // Note that USB keycodes are not part of any web standard.
   // Please don't use USB keycodes in new code.
 
@@ skipping 21 matching lines @@
   static const KeycodeMapEntry* GetKeycodeMapForTest();
   static const char* DomKeyStringForTest(size_t index);
 
  private:
   DISALLOW_COPY_AND_ASSIGN(KeycodeConverter);
 };
 
 }  // namespace ui
 
 #endif  // UI_EVENTS_KEYCODES_DOM4_KEYCODE_CONVERTER_H_