Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1120253002: [bindings] Remove usage of custom binding for namedPropertyQuery of CSSStyleDeclaration (Closed)

Created:
5 years, 7 months ago by vivekg_samsung
Modified:
5 years, 7 months ago
Reviewers:
haraken, vivekg
CC:
vivekg, darktears, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, Inactive, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Remove usage of custom binding for namedPropertyQuery of CSSStyleDeclaration BUG=345519 R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194846

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/css/CSSStyleDeclaration.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSStyleDeclaration.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/css/CSSStyleDeclaration.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
vivekg
PTAL, thanks.
5 years, 7 months ago (2015-05-02 22:10:11 UTC) #2
haraken
LGTM
5 years, 7 months ago (2015-05-03 03:51:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120253002/1
5 years, 7 months ago (2015-05-03 03:53:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=194846
5 years, 7 months ago (2015-05-03 04:45:55 UTC) #6
vivekg
5 years, 7 months ago (2015-05-14 16:23:49 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1134423002/ by vivekg@chromium.org.

The reason for reverting is: Reverting due to the dromeo.jslibstylejquery
regression

BUG=483448

TBR=haraken@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698