Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 112023009: Update Java checkstyle naming convention for static final fields. (Closed)

Created:
7 years ago by newt (away)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Update Java checkstyle naming convention for static final fields. Static final fields can either be "true" constants, e.g. static final int HEIGHT_PX = 30; static final String TAG = "MyClass" or can have mutable state or not "feel" like a constant, e.g. static final AtomicInteger sNextId; static final Runnable sSuspendTask; This allows either naming convention, FIELD_NAME or sFieldName, at the programmer's discretion. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/android/checkstyle/chromium-style-5.0.xml View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
newt (away)
7 years ago (2013-12-12 21:12:55 UTC) #1
newt (away)
ping
6 years, 11 months ago (2014-01-07 15:45:47 UTC) #2
aurimas (slooooooooow)
lgtm
6 years, 11 months ago (2014-01-07 17:13:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/112023009/1
6 years, 11 months ago (2014-01-07 17:18:05 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 17:18:22 UTC) #5
Message was sent while issue was closed.
Change committed as 243316

Powered by Google App Engine
This is Rietveld 408576698