Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: tools/android/checkstyle/chromium-style-5.0.xml

Issue 112023009: Update Java checkstyle naming convention for static final fields. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="UTF-8"?> 1 <?xml version="1.0" encoding="UTF-8"?>
2 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http: //www.puppycrawl.com/dtds/configuration_1_3.dtd"> 2 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http: //www.puppycrawl.com/dtds/configuration_1_3.dtd">
3 3
4 <!-- 4 <!--
5 See installation instructions: https://sites.google.com/a/chromium.org/dev/che ckstyle 5 See installation instructions: https://sites.google.com/a/chromium.org/dev/che ckstyle
6 --> 6 -->
7 <module name="Checker"> 7 <module name="Checker">
8 <property name="severity" value="warning"/> 8 <property name="severity" value="warning"/>
9 <property name="charset" value="UTF-8"/> 9 <property name="charset" value="UTF-8"/>
10 <module name="TreeWalker"> 10 <module name="TreeWalker">
(...skipping 28 matching lines...) Expand all
39 </module> 39 </module>
40 <module name="PackageName"> 40 <module name="PackageName">
41 <property name="severity" value="warning"/> 41 <property name="severity" value="warning"/>
42 <property name="format" value="^[a-z]+(\.[a-z][a-z0-9]{1,})*$"/> 42 <property name="format" value="^[a-z]+(\.[a-z][a-z0-9]{1,})*$"/>
43 </module> 43 </module>
44 <module name="TypeName"> 44 <module name="TypeName">
45 <property name="severity" value="warning"/> 45 <property name="severity" value="warning"/>
46 </module> 46 </module>
47 <module name="ConstantName"> 47 <module name="ConstantName">
48 <property name="severity" value="warning"/> 48 <property name="severity" value="warning"/>
49 <message key="name.invalidPattern" value="Variable ''{0}'' is a constant a nd thus should be in ALL_CAPS."/> 49 <property name="format" value="^([A-Z][A-Z0-9]*(_[A-Z0-9]+)*)|(s[A-Z][a-zA -Z0-9]*)$"/>
50 <message key="name.invalidPattern" value="Static final field names must ei ther be all caps (e.g. int HEIGHT_PX) for 'true' constants, or start with s (e.g . AtomicInteger sNextId or Runnable sSuspendTask) for fields with mutable state or that don't 'feel' like constants."/>
50 </module> 51 </module>
51 <!-- Non-public, non-static field names start with m. --> 52 <!-- Non-public, non-static field names start with m. -->
52 <module name="MemberName"> 53 <module name="MemberName">
53 <property name="format" value="^m[A-Z][a-zA-Z0-9]*$"/> 54 <property name="format" value="^m[A-Z][a-zA-Z0-9]*$"/>
54 <property name="applyToPublic" value="false"/> 55 <property name="applyToPublic" value="false"/>
55 <message key="name.invalidPattern" value="Non-public, non-static field n ames start with m."/> 56 <message key="name.invalidPattern" value="Non-public, non-static field n ames start with m."/>
56 </module> 57 </module>
57 <!-- Static field names start with s. --> 58 <!-- Static field names start with s. -->
58 <module name="StaticVariableName"> 59 <module name="StaticVariableName">
59 <property name="format" value="^s[A-Z][a-zA-Z0-9]*$"/> 60 <property name="format" value="^s[A-Z][a-zA-Z0-9]*$"/>
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 <module name="RegexpSingleline"> 149 <module name="RegexpSingleline">
149 <property name="severity" value="error"/> 150 <property name="severity" value="error"/>
150 <property name="format" value="[ \t]+$"/> 151 <property name="format" value="[ \t]+$"/>
151 <property name="message" value="Trailing whitespace"/> 152 <property name="message" value="Trailing whitespace"/>
152 </module> 153 </module>
153 <module name="RegexpHeader"> 154 <module name="RegexpHeader">
154 <property name="severity" value="error"/> 155 <property name="severity" value="error"/>
155 <property name="header" value="^// Copyright 20\d\d The Chromium Authors. Al l rights reserved.$\n^// Use of this source code is governed by a BSD-style lice nse that can be$\n^// found in the LICENSE file.$"/> 156 <property name="header" value="^// Copyright 20\d\d The Chromium Authors. Al l rights reserved.$\n^// Use of this source code is governed by a BSD-style lice nse that can be$\n^// found in the LICENSE file.$"/>
156 </module> 157 </module>
157 </module> 158 </module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698