Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: runtime/observatory/lib/src/elements/isolate_view.dart

Issue 1120133002: Rework error handling in the service protocol and in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/isolate_view.dart
diff --git a/runtime/observatory/lib/src/elements/isolate_view.dart b/runtime/observatory/lib/src/elements/isolate_view.dart
index 787b1f0604bdfe712e7db2f58d192ea535135886..db65066face224a5906e25a5357a0ae77c0f22cc 100644
--- a/runtime/observatory/lib/src/elements/isolate_view.dart
+++ b/runtime/observatory/lib/src/elements/isolate_view.dart
@@ -121,29 +121,11 @@ class IsolateViewElement extends ObservatoryElement {
}
}
- void refresh(var done) {
- isolate.reload().whenComplete(done);
+ Future refresh() {
+ return isolate.reload();
}
- void refreshCoverage(var done) {
- isolate.refreshCoverage().whenComplete(done);
- }
-
- Future pause(_) {
- return isolate.pause().then((result) {
- // TODO(turnidge): Instead of asserting here, handle errors
- // properly.
- assert(result.type == 'Success');
- return isolate.reload();
- });
- }
-
- Future resume(_) {
- return isolate.resume().then((result) {
- // TODO(turnidge): Instead of asserting here, handle errors
- // properly.
- assert(result.type == 'Success');
- return isolate.reload();
- });
+ Future refreshCoverage() {
+ return isolate.refreshCoverage();
}
}
« no previous file with comments | « runtime/observatory/lib/src/elements/isolate_reconnect.dart ('k') | runtime/observatory/lib/src/elements/library_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698