Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: runtime/observatory/lib/src/elements/isolate_view.dart

Issue 1120133002: Rework error handling in the service protocol and in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library isolate_view_element; 5 library isolate_view_element;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'observatory_element.dart'; 8 import 'observatory_element.dart';
9 import 'package:observatory/app.dart'; 9 import 'package:observatory/app.dart';
10 import 'package:observatory/service.dart'; 10 import 'package:observatory/service.dart';
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 } 114 }
115 } 115 }
116 116
117 void _drawTagProfileChart() { 117 void _drawTagProfileChart() {
118 var element = shadowRoot.querySelector('#tagProfileChart'); 118 var element = shadowRoot.querySelector('#tagProfileChart');
119 if (element != null) { 119 if (element != null) {
120 tagProfileChart.draw(element); 120 tagProfileChart.draw(element);
121 } 121 }
122 } 122 }
123 123
124 void refresh(var done) { 124 Future refresh() {
125 isolate.reload().whenComplete(done); 125 return isolate.reload();
126 } 126 }
127 127
128 void refreshCoverage(var done) { 128 Future refreshCoverage() {
129 isolate.refreshCoverage().whenComplete(done); 129 return isolate.refreshCoverage();
130 }
131
132 Future pause(_) {
133 return isolate.pause().then((result) {
134 // TODO(turnidge): Instead of asserting here, handle errors
135 // properly.
136 assert(result.type == 'Success');
137 return isolate.reload();
138 });
139 }
140
141 Future resume(_) {
142 return isolate.resume().then((result) {
143 // TODO(turnidge): Instead of asserting here, handle errors
144 // properly.
145 assert(result.type == 'Success');
146 return isolate.reload();
147 });
148 } 130 }
149 } 131 }
OLDNEW
« no previous file with comments | « runtime/observatory/lib/src/elements/isolate_reconnect.dart ('k') | runtime/observatory/lib/src/elements/library_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698