Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: runtime/observatory/lib/src/elements/eval_box.html

Issue 1120133002: Rework error handling in the service protocol and in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 <link rel="import" href="../../../../packages/polymer/polymer.html"> 1 <link rel="import" href="../../../../packages/polymer/polymer.html">
2 <link rel="import" href="instance_ref.html"> 2 <link rel="import" href="instance_ref.html">
3 <link rel="import" href="error_ref.html"> 3 <link rel="import" href="error_ref.html">
4 <link rel="import" href="observatory_element.html"> 4 <link rel="import" href="observatory_element.html">
5 5
6 <polymer-element name="eval-box" extends="observatory-element"> 6 <polymer-element name="eval-box" extends="observatory-element">
7 <template> 7 <template>
8 <style> 8 <style>
9 .textbox { 9 .textbox {
10 flex-grow: 1; 10 flex-grow: 1;
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 67
68 <br> 68 <br>
69 <template if="{{ results.isNotEmpty }}"> 69 <template if="{{ results.isNotEmpty }}">
70 <table> 70 <table>
71 <tr template repeat="{{ result in results }}"> 71 <tr template repeat="{{ result in results }}">
72 <td class="historyExpr"> 72 <td class="historyExpr">
73 <a class="expr" on-click="{{ selectExpr }}" 73 <a class="expr" on-click="{{ selectExpr }}"
74 expr="{{ result['expr'] }}">{{ result['expr'] }}</a> 74 expr="{{ result['expr'] }}">{{ result['expr'] }}</a>
75 </td> 75 </td>
76 <td class="historyValue"> 76 <td class="historyValue">
77 <template if="{{ result['value'] == null }}"> 77 <template if="{{ result['error'] != null}}">
78 <div style="color:#aaa;cursor:wait;">&lt;pending&gt;</div> 78 <div style="color:red">{{ result['error'] }}</div>
79 </template> 79 </template>
80 <template if="{{ result['value'] != null }}"> 80 <template if="{{ result['error'] == null}}">
81 <any-service-ref ref="{{ result['value'] }}"></any-service-ref> 81 <template if="{{ result['value'] != null }}">
82 <any-service-ref ref="{{ result['value'] }}"></any-service-ref>
83 </template>
84 <template if="{{ result['value'] == null }}">
85 <div style="color:#aaa;cursor:wait;">&lt;pending&gt;</div>
86 </template>
82 </template> 87 </template>
83 </td> 88 </td>
84 </tr> 89 </tr>
85 </table> 90 </table>
86 </template> 91 </template>
87 </template> 92 </template>
88 </polymer-element> 93 </polymer-element>
89 94
90 <script type="application/dart" src="eval_box.dart"></script> 95 <script type="application/dart" src="eval_box.dart"></script>
OLDNEW
« no previous file with comments | « runtime/observatory/lib/src/elements/eval_box.dart ('k') | runtime/observatory/lib/src/elements/eval_link.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698