Rework error handling in the service protocol and in Observatory.

runtime/observatory/lib/src/elements/eval_link.dart

Index: runtime/observatory/lib/src/elements/eval_link.dart
diff --git a/runtime/observatory/lib/src/elements/eval_link.dart b/runtime/observatory/lib/src/elements/eval_link.dart
index e13aed127cc24f3a85afe91959748e1da80904db..dd36736fde39f19d775da2b2c74e3a72ebade71a 100644
--- a/runtime/observatory/lib/src/elements/eval_link.dart
+++ b/runtime/observatory/lib/src/elements/eval_link.dart
@@ -5,17 +5,19 @@
 library eval_link_element;
 
 import 'package:observatory/service.dart';
+import 'observatory_element.dart';
 import 'package:polymer/polymer.dart';
 
 @CustomTag('eval-link')
-class EvalLinkElement extends PolymerElement {
+class EvalLinkElement extends ObservatoryElement {
   EvalLinkElement.created() : super.created();
 
   @observable bool busy = false;
   @published String label = "[evaluate]";
   @published var callback = null;
   @published var expr = '';
-  @published ServiceObject result = null;
+  @published var result = null;
+  @published var error = null;
 
   void evalNow(var a, var b, var c) {
     if (busy) {
@@ -25,10 +27,14 @@ class EvalLinkElement extends PolymerElement {
       busy = true;
       result = null;
       callback(expr).then((ServiceObject obj) {
-          result = obj;
-        }).whenComplete(() {
-          busy = false;
-        });
+        result = obj;
+      }).catchError((e, st) {
+        busy = false;

[Cutch, 2015/05/13 17:50:09]

is this busy = false; necessary? won't the whenComplete handle this?

[turnidge, 2015/05/14 17:53:42]

Done.

+        error = e.message;
+        app.handleException(e, st);
+      }).whenComplete(() {
+        busy = false;
+      });
     }
   }
 }