runtime/observatory/lib/src/elements/eval_box.html - Issue 1120133002: Rework error handling in the service protocol and in Observatory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/eval_box.html

Issue 1120133002: Rework error handling in the service protocol and in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/observatory/lib/src/app/application.dart ('K') | « runtime/observatory/lib/src/elements/eval_box.dart ('k') | runtime/observatory/lib/src/elements/eval_link.dart » ('j') | runtime/observatory/lib/src/elements/eval_link.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/lib/src/elements/eval_box.html

diff --git a/runtime/observatory/lib/src/elements/eval_box.html b/runtime/observatory/lib/src/elements/eval_box.html

index b556358ec721fdf3586403115ae520794e3cef86..4df73fa1b7acd8966bb7a5d76bab05681f50252b 100644

--- a/runtime/observatory/lib/src/elements/eval_box.html

+++ b/runtime/observatory/lib/src/elements/eval_box.html

@@ -74,11 +74,16 @@

expr="{{ result['expr'] }}">{{ result['expr'] }}</a>

</td>

- <template if="{{ result['value'] == null }}">

- <div style="color:#aaa;cursor:wait;"><pending></div>

+ <template if="{{ result['error'] != null}}">

+ <div style="color:red">{{ result['error'] }}</div>

</template>

- <template if="{{ result['value'] != null }}">

- <any-service-ref ref="{{ result['value'] }}"></any-service-ref>

+ <template if="{{ result['error'] == null}}">

+ <template if="{{ result['value'] != null }}">

+ <any-service-ref ref="{{ result['value'] }}"></any-service-ref>

+ </template>

+ <template if="{{ result['value'] == null }}">

+ <div style="color:#aaa;cursor:wait;"><pending></div>

+ </template>

</template>

</td>

</tr>