Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1120093005: Adjust the visibility of the standalone targets in the GN build. (Closed)

Created:
5 years, 7 months ago by Dirk Pranke
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adjust the visibility of the standalone targets in the GN build. As part of the migration from GYP->GN, we want to make sure that we can track when new targets are added to either the GYP or GN builds and that we are building everything we expect to build. In GN, unlike GYP, if a build file gets referenced from other files, building 'all' will cause every target to be built in it. This means in particular, that we can end up trying to build targets that are not necessarily intended to be visible to the rest of the build. To get around this, any target that is defined but hidden (like 'v8_snapshot', in V8's case) should still be visible to a top-level target called "//:gn_visibility". R=brettw@chromium.org, machenbach@chromium.org BUG=461019 LOG=N Committed: https://crrev.com/978acb8d5eff56d924fef6af63582ccf2497b437 Cr-Commit-Position: refs/heads/master@{#28243}

Patch Set 1 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M BUILD.gn View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Dirk Pranke
5 years, 7 months ago (2015-05-01 20:56:53 UTC) #1
Dirk Pranke
5 years, 7 months ago (2015-05-01 21:00:03 UTC) #3
Michael Achenbach
lgtm
5 years, 7 months ago (2015-05-04 15:26:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120093005/20001
5 years, 7 months ago (2015-05-05 19:44:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/2471)
5 years, 7 months ago (2015-05-05 19:47:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120093005/20001
5 years, 7 months ago (2015-05-05 19:49:00 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-05 21:16:25 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 21:16:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/978acb8d5eff56d924fef6af63582ccf2497b437
Cr-Commit-Position: refs/heads/master@{#28243}

Powered by Google App Engine
This is Rietveld 408576698