Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: BUILD.gn

Issue 1120093005: Adjust the visibility of the standalone targets in the GN build. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 64d75020051038fb7ba03f3f6eed9de9340af3b3..a48e78d71d50ec3bf2c674bd075cdd52c7e58701 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -338,7 +338,12 @@ if (v8_use_external_startup_data) {
}
action("postmortem-metadata") {
- visibility = [ ":*" ] # Only targets in this file can depend on this.
+ # Only targets in this file and the top-level visibility target can
+ # depend on this.
+ visibility = [
+ ":*",
+ "//:gn_visibility",
+ ]
script = "tools/gen-postmortem-metadata.py"
@@ -423,7 +428,12 @@ source_set("v8_nosnapshot") {
}
source_set("v8_snapshot") {
- visibility = [ ":*" ] # Only targets in this file can depend on this.
+ # Only targets in this file and the top-level visibility target can
+ # depend on this.
+ visibility = [
+ ":*",
+ "//:gn_visibility",
+ ]
deps = [
":js2c",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698