Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: Source/core/svg/SVGElement.cpp

Issue 112003003: [SVG] SVGLength{,List} migration to new SVG property impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaselined Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGElement.cpp
diff --git a/Source/core/svg/SVGElement.cpp b/Source/core/svg/SVGElement.cpp
index a42e4533450c415577d4a7ef97dfe7f0d36fca35..e214aa77f9a232a975729bef028b366e48659d9f 100644
--- a/Source/core/svg/SVGElement.cpp
+++ b/Source/core/svg/SVGElement.cpp
@@ -777,7 +777,7 @@ void SVGElement::animatedPropertyTypeForAttribute(const QualifiedName& attribute
return;
if (m_newAttributeToPropertyMap.contains(attributeName))
- propertyTypes.append(AnimatedNewProperty);
+ propertyTypes.append(AnimatedNewProperty); // FIXME
pdr. 2014/01/07 06:42:53 Does this need fixed?
kouhei (in TOK) 2014/01/07 09:22:28 This is fixed in http://src.chromium.org/viewvc/bl
AttributeToPropertyTypeMap& cssPropertyTypeMap = cssPropertyToTypeMap();
if (cssPropertyTypeMap.contains(attributeName))
@@ -1055,7 +1055,8 @@ void SVGElement::synchronizeAnimatedSVGAttribute(const QualifiedName& name) cons
AttributeToPropertyMap::const_iterator::Values it = m_newAttributeToPropertyMap.values().begin();
AttributeToPropertyMap::const_iterator::Values end = m_newAttributeToPropertyMap.values().end();
for (; it != end; ++it) {
- (*it)->synchronizeAttribute();
+ if ((*it)->needsSynchronizeAttribute())
+ (*it)->synchronizeAttribute();
}
elementData()->m_animatedSVGAttributesAreDirty = false;
@@ -1063,7 +1064,7 @@ void SVGElement::synchronizeAnimatedSVGAttribute(const QualifiedName& name) cons
nonConstThis->localAttributeToPropertyMap().synchronizeProperty(nonConstThis, name);
RefPtr<NewSVGAnimatedPropertyBase> property = m_newAttributeToPropertyMap.get(name);
- if (property)
+ if (property && property->needsSynchronizeAttribute())
property->synchronizeAttribute();
}
}

Powered by Google App Engine
This is Rietveld 408576698