Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Side by Side Diff: Source/core/svg/SVGElement.cpp

Issue 112003003: [SVG] SVGLength{,List} migration to new SVG property impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaselined Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org> 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org>
3 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org>
4 * Copyright (C) 2008 Apple Inc. All rights reserved. 4 * Copyright (C) 2008 Apple Inc. All rights reserved.
5 * Copyright (C) 2008 Alp Toker <alp@atoker.com> 5 * Copyright (C) 2008 Alp Toker <alp@atoker.com>
6 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 6 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 759 matching lines...) Expand 10 before | Expand all | Expand 10 after
770 return s_cssPropertyMap; 770 return s_cssPropertyMap;
771 } 771 }
772 772
773 void SVGElement::animatedPropertyTypeForAttribute(const QualifiedName& attribute Name, Vector<AnimatedPropertyType>& propertyTypes) 773 void SVGElement::animatedPropertyTypeForAttribute(const QualifiedName& attribute Name, Vector<AnimatedPropertyType>& propertyTypes)
774 { 774 {
775 localAttributeToPropertyMap().animatedPropertyTypeForAttribute(attributeName , propertyTypes); 775 localAttributeToPropertyMap().animatedPropertyTypeForAttribute(attributeName , propertyTypes);
776 if (!propertyTypes.isEmpty()) 776 if (!propertyTypes.isEmpty())
777 return; 777 return;
778 778
779 if (m_newAttributeToPropertyMap.contains(attributeName)) 779 if (m_newAttributeToPropertyMap.contains(attributeName))
780 propertyTypes.append(AnimatedNewProperty); 780 propertyTypes.append(AnimatedNewProperty); // FIXME
pdr. 2014/01/07 06:42:53 Does this need fixed?
kouhei (in TOK) 2014/01/07 09:22:28 This is fixed in http://src.chromium.org/viewvc/bl
781 781
782 AttributeToPropertyTypeMap& cssPropertyTypeMap = cssPropertyToTypeMap(); 782 AttributeToPropertyTypeMap& cssPropertyTypeMap = cssPropertyToTypeMap();
783 if (cssPropertyTypeMap.contains(attributeName)) 783 if (cssPropertyTypeMap.contains(attributeName))
784 propertyTypes.append(cssPropertyTypeMap.get(attributeName)); 784 propertyTypes.append(cssPropertyTypeMap.get(attributeName));
785 } 785 }
786 786
787 void SVGElement::addToPropertyMap(PassRefPtr<NewSVGAnimatedPropertyBase> passPro perty) 787 void SVGElement::addToPropertyMap(PassRefPtr<NewSVGAnimatedPropertyBase> passPro perty)
788 { 788 {
789 RefPtr<NewSVGAnimatedPropertyBase> property(passProperty); 789 RefPtr<NewSVGAnimatedPropertyBase> property(passProperty);
790 QualifiedName attributeName = property->attributeName(); 790 QualifiedName attributeName = property->attributeName();
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
1048 if (!elementData() || !elementData()->m_animatedSVGAttributesAreDirty) 1048 if (!elementData() || !elementData()->m_animatedSVGAttributesAreDirty)
1049 return; 1049 return;
1050 1050
1051 SVGElement* nonConstThis = const_cast<SVGElement*>(this); 1051 SVGElement* nonConstThis = const_cast<SVGElement*>(this);
1052 if (name == anyQName()) { 1052 if (name == anyQName()) {
1053 nonConstThis->localAttributeToPropertyMap().synchronizeProperties(nonCon stThis); 1053 nonConstThis->localAttributeToPropertyMap().synchronizeProperties(nonCon stThis);
1054 1054
1055 AttributeToPropertyMap::const_iterator::Values it = m_newAttributeToProp ertyMap.values().begin(); 1055 AttributeToPropertyMap::const_iterator::Values it = m_newAttributeToProp ertyMap.values().begin();
1056 AttributeToPropertyMap::const_iterator::Values end = m_newAttributeToPro pertyMap.values().end(); 1056 AttributeToPropertyMap::const_iterator::Values end = m_newAttributeToPro pertyMap.values().end();
1057 for (; it != end; ++it) { 1057 for (; it != end; ++it) {
1058 (*it)->synchronizeAttribute(); 1058 if ((*it)->needsSynchronizeAttribute())
1059 (*it)->synchronizeAttribute();
1059 } 1060 }
1060 1061
1061 elementData()->m_animatedSVGAttributesAreDirty = false; 1062 elementData()->m_animatedSVGAttributesAreDirty = false;
1062 } else { 1063 } else {
1063 nonConstThis->localAttributeToPropertyMap().synchronizeProperty(nonConst This, name); 1064 nonConstThis->localAttributeToPropertyMap().synchronizeProperty(nonConst This, name);
1064 1065
1065 RefPtr<NewSVGAnimatedPropertyBase> property = m_newAttributeToPropertyMa p.get(name); 1066 RefPtr<NewSVGAnimatedPropertyBase> property = m_newAttributeToPropertyMa p.get(name);
1066 if (property) 1067 if (property && property->needsSynchronizeAttribute())
1067 property->synchronizeAttribute(); 1068 property->synchronizeAttribute();
1068 } 1069 }
1069 } 1070 }
1070 1071
1071 void SVGElement::synchronizeRequiredFeatures(SVGElement* contextElement) 1072 void SVGElement::synchronizeRequiredFeatures(SVGElement* contextElement)
1072 { 1073 {
1073 ASSERT(contextElement); 1074 ASSERT(contextElement);
1074 contextElement->synchronizeRequiredFeatures(); 1075 contextElement->synchronizeRequiredFeatures();
1075 } 1076 }
1076 1077
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
1243 animatableAttributes.add(SVGNames::zAttr); 1244 animatableAttributes.add(SVGNames::zAttr);
1244 } 1245 }
1245 1246
1246 if (name == classAttr) 1247 if (name == classAttr)
1247 return true; 1248 return true;
1248 1249
1249 return animatableAttributes.contains(name); 1250 return animatableAttributes.contains(name);
1250 } 1251 }
1251 #endif 1252 #endif
1252 } 1253 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698