Source/core/svg/SVGAnimateElement.cpp - Issue 112003003: [SVG] SVGLength{,List} migration to new SVG property impl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGAnimateElement.cpp

Issue 112003003: [SVG] SVGLength{,List} migration to new SVG property impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebaselined Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGAnimateElement.cpp

diff --git a/Source/core/svg/SVGAnimateElement.cpp b/Source/core/svg/SVGAnimateElement.cpp

index 4d171f298a8c4e0695e4874e193ba57701138408..b0a0a154d8a2ab70f7fe5ea4f9b530bc188ce210 100644

--- a/Source/core/svg/SVGAnimateElement.cpp

+++ b/Source/core/svg/SVGAnimateElement.cpp

@@ -238,10 +238,8 @@ void SVGAnimateElement::resetAnimatedType()

computeCSSPropertyValue(targetElement, cssPropertyID(attributeName.localName()), baseValue);

}

- if (!m_animatedType)

+ if (!m_animatedType || !m_animatedType->setValueAsString(attributeName, baseValue))

m_animatedType = animator->constructFromString(baseValue);

- else

- m_animatedType->setValueAsString(attributeName, baseValue);

}

static inline void applyCSSPropertyToTarget(SVGElement* targetElement, CSSPropertyID id, const String& value)