Source/core/animation/ElementAnimations.cpp - Issue 1120003002: [Oilpan] Migrate most classes under core/animations to Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/ElementAnimations.cpp

Issue 1120003002: [Oilpan] Migrate most classes under core/animations to Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Intentional nullptr access Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/animation/AnimationTimelineTest.cpp ('K') | « Source/core/animation/ElementAnimations.h ('k') | Source/core/animation/FilterStyleInterpolation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/ElementAnimations.cpp

diff --git a/Source/core/animation/ElementAnimations.cpp b/Source/core/animation/ElementAnimations.cpp

index 86bee848ef2f11d7dbad838d16f62034caf42ed1..5e6b747d040d588fa939fd1ffe8b02373923c7ed 100644

--- a/Source/core/animation/ElementAnimations.cpp

+++ b/Source/core/animation/ElementAnimations.cpp

@@ -42,6 +42,10 @@ ElementAnimations::ElementAnimations()

ElementAnimations::~ElementAnimations()

{

+void ElementAnimations::dispose()

#if !ENABLE(OILPAN)

for (KeyframeEffect* effect : m_effects)

effect->notifyElementDestroyed();

@@ -83,11 +87,14 @@ void ElementAnimations::restartAnimationOnCompositor()

DEFINE_TRACE(ElementAnimations)

{

-#if ENABLE(OILPAN)

visitor->trace(m_cssAnimations);

visitor->trace(m_defaultStack);

+#if ENABLE(OILPAN)

visitor->trace(m_animations);

#endif

+#if !ENABLE(OILPAN)

+ visitor->trace(m_effects);

+#endif

}

const ComputedStyle* ElementAnimations::baseComputedStyle() const