Source/web/WebRemoteFrameImpl.h - Issue 1119823003: Allow createLocalChild to specify previous sibling frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebRemoteFrameImpl.h

Issue 1119823003: Allow createLocalChild to specify previous sibling frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Change appendChild to use insertAfter Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebRemoteFrameImpl.h

diff --git a/Source/web/WebRemoteFrameImpl.h b/Source/web/WebRemoteFrameImpl.h

index 6b16f26ea8275cf618c061e81c6c6712a6be052e..a092a9999faa3805607a2d1dc9ff0285046f6469 100644

--- a/Source/web/WebRemoteFrameImpl.h

+++ b/Source/web/WebRemoteFrameImpl.h

@@ -168,7 +168,9 @@ public:

virtual bool selectionStartHasSpellingMarkerFor(int from, int length) const override;

virtual WebString layerTreeAsText(bool showDebugInfo = false) const override;

+ // TODO(alexmos): Remove once Chromium side is updated to take previous sibling.

virtual WebLocalFrame* createLocalChild(const WebString& name, WebSandboxFlags, WebFrameClient*) override;

+ virtual WebLocalFrame* createLocalChild(const WebString& name, WebSandboxFlags, WebFrameClient*, WebFrame*) override;

virtual WebRemoteFrame* createRemoteChild(const WebString& name, WebSandboxFlags, WebRemoteFrameClient*) override;

void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString& name);

« no previous file with comments | « Source/web/WebFrame.cpp ('k') | Source/web/WebRemoteFrameImpl.cpp » ('j') | Source/web/tests/WebFrameTest.cpp » ('J')