Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: Source/web/WebRemoteFrameImpl.h

Issue 1119823003: Allow createLocalChild to specify previous sibling frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Change appendChild to use insertAfter Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebRemoteFrameImpl_h 5 #ifndef WebRemoteFrameImpl_h
6 #define WebRemoteFrameImpl_h 6 #define WebRemoteFrameImpl_h
7 7
8 #include "core/frame/FrameOwner.h" 8 #include "core/frame/FrameOwner.h"
9 #include "platform/heap/Handle.h" 9 #include "platform/heap/Handle.h"
10 #include "public/web/WebRemoteFrame.h" 10 #include "public/web/WebRemoteFrame.h"
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 161
162 virtual WebString contentAsText(size_t maxChars) const override; 162 virtual WebString contentAsText(size_t maxChars) const override;
163 virtual WebString contentAsMarkup() const override; 163 virtual WebString contentAsMarkup() const override;
164 virtual WebString layoutTreeAsText(LayoutAsTextControls toShow = LayoutAsTex tNormal) const override; 164 virtual WebString layoutTreeAsText(LayoutAsTextControls toShow = LayoutAsTex tNormal) const override;
165 virtual WebString markerTextForListItem(const WebElement&) const override; 165 virtual WebString markerTextForListItem(const WebElement&) const override;
166 virtual WebRect selectionBoundsRect() const override; 166 virtual WebRect selectionBoundsRect() const override;
167 167
168 virtual bool selectionStartHasSpellingMarkerFor(int from, int length) const override; 168 virtual bool selectionStartHasSpellingMarkerFor(int from, int length) const override;
169 virtual WebString layerTreeAsText(bool showDebugInfo = false) const override ; 169 virtual WebString layerTreeAsText(bool showDebugInfo = false) const override ;
170 170
171 // TODO(alexmos): Remove once Chromium side is updated to take previous sibl ing.
171 virtual WebLocalFrame* createLocalChild(const WebString& name, WebSandboxFla gs, WebFrameClient*) override; 172 virtual WebLocalFrame* createLocalChild(const WebString& name, WebSandboxFla gs, WebFrameClient*) override;
173 virtual WebLocalFrame* createLocalChild(const WebString& name, WebSandboxFla gs, WebFrameClient*, WebFrame*) override;
172 virtual WebRemoteFrame* createRemoteChild(const WebString& name, WebSandboxF lags, WebRemoteFrameClient*) override; 174 virtual WebRemoteFrame* createRemoteChild(const WebString& name, WebSandboxF lags, WebRemoteFrameClient*) override;
173 175
174 void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString& name); 176 void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString& name);
175 177
176 void setCoreFrame(PassRefPtrWillBeRawPtr<RemoteFrame>); 178 void setCoreFrame(PassRefPtrWillBeRawPtr<RemoteFrame>);
177 RemoteFrame* frame() const { return m_frame.get(); } 179 RemoteFrame* frame() const { return m_frame.get(); }
178 180
179 WebRemoteFrameClient* client() const { return m_client; } 181 WebRemoteFrameClient* client() const { return m_client; }
180 182
181 static WebRemoteFrameImpl* fromFrame(RemoteFrame&); 183 static WebRemoteFrameImpl* fromFrame(RemoteFrame&);
(...skipping 29 matching lines...) Expand all
211 GC_PLUGIN_IGNORE("340522") 213 GC_PLUGIN_IGNORE("340522")
212 Persistent<WebRemoteFrameImpl> m_selfKeepAlive; 214 Persistent<WebRemoteFrameImpl> m_selfKeepAlive;
213 #endif 215 #endif
214 }; 216 };
215 217
216 DEFINE_TYPE_CASTS(WebRemoteFrameImpl, WebFrame, frame, frame->isWebRemoteFrame() , frame.isWebRemoteFrame()); 218 DEFINE_TYPE_CASTS(WebRemoteFrameImpl, WebFrame, frame, frame->isWebRemoteFrame() , frame.isWebRemoteFrame());
217 219
218 } // namespace blink 220 } // namespace blink
219 221
220 #endif // WebRemoteFrameImpl_h 222 #endif // WebRemoteFrameImpl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698