Issue 11198005: NOT READY FOR REVIEW - switch to a subscriber model for rendering stats

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11198005: NOT READY FOR REVIEW - switch to a subscriber model for rendering stats (Closed)

Created:
8 years, 2 months ago by Ian Vollick

Modified:
7 years, 6 months ago

Reviewers:

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

NOT READY FOR REVIEW - switch to a subscriber model for rendering stats Currently, we use CCLTH::renderingStats(...) to collect our stats. It would make more sense if we were to subscribe for a period of time and collect the stats afterwards. BUG=155136

Patch Set 1 #

Patch Set 2 : Rendering stats now know which properies were modified. #

Patch Set 3 : . #

Patch Set 4 : Added some guts to the subscriber. #

Patch Set 5 : Rebased (most of the work done by hartmanng -- thanks, Glenn!) #

Patch Set 6 : Added missing file. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+282 lines, -14 lines)			Patch
M	cc/cc.gyp	View	1 2 3 4	2 chunks	+3 lines, -0 lines	0 comments	Download
M	cc/layer_tree_host.h	View	1 2 3 4	3 chunks	+8 lines, -0 lines	0 comments	Download
M	cc/layer_tree_host.cc	View	1 2 3 4	2 chunks	+14 lines, -0 lines	0 comments	Download
M	cc/layer_tree_host_impl.h	View	1 2 3 4	3 chunks	+4 lines, -0 lines	0 comments	Download
M	cc/layer_tree_host_impl.cc	View	1 2 3 4	3 chunks	+25 lines, -1 line	0 comments	Download
M	cc/proxy.h	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/rendering_stats.h	View	1 2 3 4	2 chunks	+4 lines, -13 lines	0 comments	Download
A	cc/rendering_stats.cc	View	1 2 3 4 5	1 chunk	+25 lines, -0 lines	0 comments	Download
A	cc/rendering_stats_subscriber.h	View	1 2 3	1 chunk	+40 lines, -0 lines	0 comments	Download
A	cc/rendering_stats_subscriber.cc	View	1 2 3	1 chunk	+85 lines, -0 lines	0 comments	Download
M	cc/single_thread_proxy.h	View	1 2 3 4	3 chunks	+4 lines, -0 lines	0 comments	Download
M	cc/single_thread_proxy.cc	View	1 2 3 4	2 chunks	+18 lines, -0 lines	0 comments	Download
M	cc/thread_proxy.h	View	1 2 3 4	4 chunks	+7 lines, -0 lines	0 comments	Download
M	cc/thread_proxy.cc	View	1 2 3 4	3 chunks	+43 lines, -0 lines	0 comments	Download