Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1119753004: Merge to XFA: Fix issues with != and == in fx_basic_wstring (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -73 lines) Patch
M core/include/fxcrt/fx_string.h View 5 chunks +44 lines, -19 lines 0 comments Download
M core/src/fxcrt/fx_basic_wstring.cpp View 2 chunks +23 lines, -35 lines 0 comments Download
M core/src/fxcrt/fx_basic_wstring_unittest.cpp View 7 chunks +2 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
TBR'd.
5 years, 7 months ago (2015-05-04 22:27:08 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as 3d33c90cfed96a8e5ce707a025e8efd59ce1ca01 (presubmit successful).
5 years, 7 months ago (2015-05-04 22:29:46 UTC) #2
Lei Zhang
5 years, 7 months ago (2015-05-04 22:34:40 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698