Fix issues with != and == in fx_basic_wstring

Fix issues with != and == in fx_basic_wstring

Part two.  Fix same issue in wide strings as in their bytestring
counterparts.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/aadcd71ab29f588d4997ec25855f60f5866959f2

[Tom Sepez, 2015-05-04 21:48:17]

Lei, second half for review.

[Lei Zhang, 2015-05-04 22:16:41]

lgtm

[Tom Sepez, 2015-05-04 22:20:33]

Committed patchset #2 (id:20001) manually as
aadcd71ab29f588d4997ec25855f60f5866959f2 (presubmit successful).

[dreamfly912, 2015-05-13 09:48:24]

dreamfly912@gmail.com changed reviewers:
+ dreamfly912@gmail.com

[dreamfly912, 2015-05-13 09:48:24]

Hello Tom and Lei,
I just found a bug, please review the comment:)

---
Hi, consider this:
CFX_WideString left;
assert(left == L"");

Here may be error to return false..

https://codereview.chromium.org/1127753002/diff/20001/core/src/fxcrt/fx_basic...
File core/src/fxcrt/fx_basic_wstring.cpp (right):

https://codereview.chromium.org/1127753002/diff/20001/core/src/fxcrt/fx_basic...
core/src/fxcrt/fx_basic_wstring.cpp:211: return !ptr;
Hi, consider this:
CFX_WideString left;
assert(left == L"");

Here may be error to return false..

[Tom Sepez, 2015-05-13 16:38:54]

On 2015/05/13 09:48:24, dreamfly912 wrote:
> Hello Tom and Lei,
> I just found a bug, please review the comment:)
> 
> ---
> Hi, consider this:
> CFX_WideString left;
> assert(left == L"");
> 
> Here may be error to return false..
> 
>
https://codereview.chromium.org/1127753002/diff/20001/core/src/fxcrt/fx_basic...
> File core/src/fxcrt/fx_basic_wstring.cpp (right):
> 
>
https://codereview.chromium.org/1127753002/diff/20001/core/src/fxcrt/fx_basic...
> core/src/fxcrt/fx_basic_wstring.cpp:211: return !ptr;
> Hi, consider this:
> CFX_WideString left;
> assert(left == L"");
> 
> Here may be error to return false..
Thanks, I'll look into it.

[Tom Sepez, 2015-05-13 17:02:01]

Filed as
https://code.google.com/p/pdfium/issues/detail?id=160