Source/core/html/track/vtt/BufferedLineReader.cpp - Issue 1119663002: Making Unicode character names consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/vtt/BufferedLineReader.cpp

Issue 1119663002: Making Unicode character names consistent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase patch Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/track/vtt/BufferedLineReader.cpp

diff --git a/Source/core/html/track/vtt/BufferedLineReader.cpp b/Source/core/html/track/vtt/BufferedLineReader.cpp

index 3401e5cab949a2f8a34863a5bf31052e5088f475..1cb81c381af96c32e42bb44dc3b275976bf0f6ea 100644

--- a/Source/core/html/track/vtt/BufferedLineReader.cpp

+++ b/Source/core/html/track/vtt/BufferedLineReader.cpp

@@ -56,10 +56,10 @@ bool BufferedLineReader::getLine(String& line)

UChar c = m_buffer.currentChar();

m_buffer.advance();

- if (c == newlineCharacter || c == carriageReturn) {

+ if (c == newlineCharacter || c == carriageReturnCharacter) {

// We found a line ending. Return the accumulated line.

shouldReturnLine = true;

- checkForLF = (c == carriageReturn);

+ checkForLF = (c == carriageReturnCharacter);

break;

}